-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.10 support (loop parameter was removed from Lock()) #916
Comments
We're going to need something like: self._drain_lock = asyncio.Lock(
**({"loop": loop} if sys.version_info[:2] < (3, 8) else {})
) There's a bunch of other instances of this pattern. I can fix them. |
Filing #935 for later. |
So, the big problem is that Python 3.10 deprecates interacting with a non-running event loop, while websockets entire test suite depends on this pattern :-( |
Hi. Has this been resolved, yet? I'm trying to use websockets with Python 3.10... |
See 5 lines above ;-) |
Hi mate, couldnt seem to find the solution, any chance of a direct link? Fairly new to the WSS side. Is it the thread 'Remove the use of get_event_loop'? Thanks in advance |
I was referring to the fact that this issue is fixed and the current version of websockets fully supports Python 3.10. |
Hi, I am getting a very similar error when using web sockets to pull Binance API data: "TypeError: As of 3.10, the loop parameter was removed from Queue() since it is no longer necessary". Is there a working solution for the issue? I can't understand the discussion above- from what I gather this is still an ongoing issue? |
How do we fix it? I am using Python 3.10 - is there a later version of something I need to install, or ... ? |
Upgrade package websockets from 9.1 to latest version |
This kind of behavior is exactly why I stopped wasting my time with crypto enthusiasts like you. |
Hello. I'm trying python 3.10 and it seems like websockets doesn't support it yet.
How to reproduce:
Get a working websockets server and try to run a client with python3.10:
This code breaks with such error:
I've looked into websockets/protocol.py:235 and there's already exist some check of python version:
But from what I understand, this is not enough to solve this problem.
The text was updated successfully, but these errors were encountered: