Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.10 compability. fix error: "As of 3.10, the *loop* parameter was removed from Lock()" #918

Closed
wants to merge 1 commit into from
Closed

Python 3.10 compability. fix error: "As of 3.10, the *loop* parameter was removed from Lock()" #918

wants to merge 1 commit into from

Conversation

SergeiMinaev
Copy link

Trying to fix #916

@SergeiMinaev
Copy link
Author

I'm sorry I don't know how to pass this CircleCI test. Not sure if this is relates to my commit.

@SergeiMinaev SergeiMinaev marked this pull request as ready for review March 11, 2021 19:07
@SergeiMinaev SergeiMinaev changed the title Fix err: "As of 3.10, the *loop* parameter was removed from Lock()" Python 3.10 support. Fix err: "As of 3.10, the *loop* parameter was removed from Lock()" Mar 11, 2021
@SergeiMinaev SergeiMinaev changed the title Python 3.10 support. Fix err: "As of 3.10, the *loop* parameter was removed from Lock()" Python 3.10 compability. Fix err: "As of 3.10, the *loop* parameter was removed from Lock()" Mar 11, 2021
@SergeiMinaev SergeiMinaev changed the title Python 3.10 compability. Fix err: "As of 3.10, the *loop* parameter was removed from Lock()" Python 3.10 compability. fix error: "As of 3.10, the *loop* parameter was removed from Lock()" Mar 11, 2021
@aaugustin
Copy link
Member

Thanks for the pull request. I investigated this today and realized that it would require fairly extensive refactoring in tests. See #936.

@aaugustin aaugustin closed this May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3.10 support (loop parameter was removed from Lock())
2 participants
@SergeiMinaev @aaugustin