Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace f-string with "...".format(...) #146

Merged
merged 1 commit into from
Jun 26, 2017
Merged

Replace f-string with "...".format(...) #146

merged 1 commit into from
Jun 26, 2017

Conversation

vstinner
Copy link
Member

Change adding Python 3.5 support.

@vstinner
Replace f-string with "...".format(...)
a7a43bd 
Change adding Python 3.5 support.
@vstinner
Copy link
Member Author

Alternate syntax of PR #143, again, to add Python 3.5 compatibility.

@vstinner vstinner mentioned this pull request Jun 26, 2017
Closed
@brettcannon brettcannon mentioned this pull request Jun 26, 2017
Merged
1st1
1st1 reviewed Jun 26, 2017
View reviewed changes
blurb/blurb.py

fields = [x.strip() for x in filename.split(".")]
assert len(fields) >= 4, f"Can't parse 'next' filename! filename {filename!r} fields {fields}"
assert len(fields) >= 4, "Can't parse 'next' filename! filename {!r} fields {}".format(filename, fields)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is surely longer than 79 characters.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PEP 8 allows up to 120 characters. The file already contains lines longer than 120 characters (before my change) ;-)

@vstinner vstinner merged commit 155f473 into python:master Jun 26, 2017
@vstinner vstinner deleted the format branch June 26, 2017 23:33
@serhiy-storchaka
Copy link
Member

Thank you for doing this @Haypo!

@serhiy-storchaka
Copy link
Member

Brett, could you please update the version on PyPI? Current version is installable on 3.5, but doesn't work.

@brettcannon
Copy link
Member

@serhiy-storchaka sure, but I'm traveling ATM so I won't be able to get to it until I return home (no later than sometime next week).

@Mariatta
Copy link
Member

Mariatta commented Jul 5, 2017

Prior to releasing to PyPI, I think this line in flit.ini should be updated so it can work with Python < 3.6.

The readme still states "blurb's only dependency is Python 3.6+.", guess that should be updated too.

@brettcannon
Copy link
Member

I updated the version number, tweaked the trove classifiers, fixed the README, pushed 1.0.1 to PyPI, and then bumped the version number for future development.

@serhiy-storchaka
Copy link
Member

Unfortunately

python3 -m pip install --user blurb

still installs version 1.0. And explicit specifying the version 1.0.1 doesn't work.

$ python3 -m pip install --user blurb==1.0.1
Collecting blurb==1.0.1
  Could not find a version that satisfies the requirement blurb==1.0.1 (from versions: 1.0)
No matching distribution found for blurb==1.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon brettcannon approved these changes

@1st1 1st1 1st1 approved these changes

@larryhastings larryhastings Awaiting requested review from larryhastings

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees
No one assigned
Labels
blurb CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vstinner @serhiy-storchaka @brettcannon @Mariatta @1st1 @the-knights-who-say-ni