Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Change single quotes to double quotes in get_author_info_from_short_sha to fix error in Windows #238
cherry_picker --continue breaks on Windows.
This happens because the process started from function get_author_info_from_short_sha is executed this way:
The single quotes don't escape the angle brackets, so cmd tries to read the non-existent file "%ae", producing a "The system cannot find the file specified" error (this can be observed in stderr after editing subprocess.py)
Using double quotes fixes this.
Environment to reproduce the issue:
Windows 10 x64
Traceback of the error:
left a comment
Just a style nit: use single quotes for consistency with the rest of the code (and this is a preferable style in Python). Double quotes was used because command line strings contained single quotes around arguments.
The rest LGTM.