Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed string module use in distutils #48235

Closed
tarekziade mannequin opened this issue Sep 28, 2008 · 6 comments
Closed

removed string module use in distutils #48235

tarekziade mannequin opened this issue Sep 28, 2008 · 6 comments
Assignees
Labels
stdlib Python modules in the Lib dir

Comments

@tarekziade
Copy link
Mannequin

tarekziade mannequin commented Sep 28, 2008

BPO 3985
Nosy @tarekziade, @ezio-melotti, @merwok, @akitada
Files
  • dist-no-string.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/tarekziade'
    closed_at = <Date 2010-08-27.21:45:05.132>
    created_at = <Date 2008-09-28.10:30:52.710>
    labels = ['library']
    title = 'removed string module use in distutils'
    updated_at = <Date 2010-08-27.21:45:05.129>
    user = 'https://github.com/tarekziade'

    bugs.python.org fields:

    activity = <Date 2010-08-27.21:45:05.129>
    actor = 'eric.araujo'
    assignee = 'tarek'
    closed = True
    closed_date = <Date 2010-08-27.21:45:05.132>
    closer = 'eric.araujo'
    components = ['Distutils', 'Distutils2']
    creation = <Date 2008-09-28.10:30:52.710>
    creator = 'tarek'
    dependencies = []
    files = ['11639']
    hgrepos = []
    issue_num = 3985
    keywords = ['patch']
    message_count = 6.0
    messages = ['73965', '83279', '102676', '102692', '110689', '115134']
    nosy_count = 5.0
    nosy_names = ['tarek', 'ezio.melotti', 'eric.araujo', 'akitada', 'BreamoreBoy']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue3985'
    versions = ['Python 3.1', 'Python 2.7']

    @tarekziade
    Copy link
    Mannequin Author

    tarekziade mannequin commented Sep 28, 2008

    This patch removes string usage from dist.py, so the module uses modern
    syntax.

    @tarekziade tarekziade mannequin added the stdlib Python modules in the Lib dir label Sep 28, 2008
    @tarekziade tarekziade mannequin changed the title removed string module from distutils removed string module from distutils [patch] Sep 28, 2008
    @tarekziade tarekziade mannequin self-assigned this Feb 6, 2009
    @akitada
    Copy link
    Mannequin

    akitada mannequin commented Mar 7, 2009

    The patch looks ok to me.
    Python 2.3 - 2.6 seem working fine with this patch, too.

    @ezio-melotti
    Copy link
    Member

    Patch looks good.
    There's only a missing space before the for in:
    + self.metadata.platforms = [kw.strip()
    + for kw in platformlist.split(',')]

    @tarekziade
    Copy link
    Mannequin Author

    tarekziade mannequin commented Apr 9, 2010

    Distutils is now frozen. Moving it to Distutils2

    @tarekziade tarekziade mannequin removed the stdlib Python modules in the Lib dir label Apr 9, 2010
    @BreamoreBoy
    Copy link
    Mannequin

    BreamoreBoy mannequin commented Jul 18, 2010

    Tarek, has this move to distutils2 taken place so we can close this, or do you wish to leave this issue open?

    @merwok
    Copy link
    Member

    merwok commented Aug 27, 2010

    Fixed in r73121 for 2.7 and years ago in 3.0. distutils2 was forked after the fix in 2.7.

    @merwok merwok added the stdlib Python modules in the Lib dir label Aug 27, 2010
    @merwok merwok closed this as completed Aug 27, 2010
    @merwok merwok changed the title removed string module from distutils [patch] removed string module use in distutils Aug 27, 2010
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    stdlib Python modules in the Lib dir
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants