-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify the pkgutil.walk_packages() note #59493
Comments
The note at the end of the pkgutil.walk_packages() (and iter_modules()) documentation can be improved somewhat: http://docs.python.org/dev/library/pkgutil.html#pkgutil.walk_packages For example, "importers" aren't referenced earlier in the documentation of the function, so it's not immediately clear what they are referring to. I also think that enough information should be given so that one can run the examples given and have them work. They currently don't. I can put together proposed wording. See the bpo-14982 discussion for background. |
Probably linking the term "importers" into the glossary should be enough. |
It seems that most, if not all, uses of "importer" in pkgutil refer to finders, e.g. ImpImporter is a actually only a finder, not an importer. So s/importer/finder/ is needed, and perhaps also a note explaining that ImpImporter isn't in fact an importer, in addition to glossary links. |
New changeset 96f7926ea444 by Brett Cannon in branch 'default': |
I changed to term to "loader" and linked to the glossary. I also added a versionchanged note for Python 3.3 so people are not too surprised that pkgutil no longer does what it did in Python 3.2. |
Ronan is right that it is all about finders, not importers per-se. I fixed the docs to not say "loader". |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: