Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding name to lzmafile #91374

Closed
ellaellela mannequin opened this issue Apr 4, 2022 · 2 comments
Closed

adding name to lzmafile #91374

ellaellela mannequin opened this issue Apr 4, 2022 · 2 comments
Labels
3.11 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@ellaellela
Copy link
Mannequin

ellaellela mannequin commented Apr 4, 2022

BPO 47218
Nosy @ellaellela
PRs
  • bpo-47218: add name to lzma fileobject #32312
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2022-04-04.18:53:55.576>
    labels = ['type-feature', 'library', '3.11']
    title = 'adding name to lzmafile'
    updated_at = <Date 2022-04-04.18:54:30.318>
    user = 'https://github.com/ellaellela'

    bugs.python.org fields:

    activity = <Date 2022-04-04.18:54:30.318>
    actor = 'ellaellela'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2022-04-04.18:53:55.576>
    creator = 'ellaellela'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 47218
    keywords = ['patch']
    message_count = 1.0
    messages = ['416691']
    nosy_count = 1.0
    nosy_names = ['ellaellela']
    pr_nums = ['32312']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue47218'
    versions = ['Python 3.11']

    @ellaellela
    Copy link
    Mannequin Author

    ellaellela mannequin commented Apr 4, 2022

    LZMAFile doesn't have attribute name, unlike GzipFile which has it. Trying to access that attribute results in error.

    PR is ready with code changes and tests which mimics what is already available for GzipFile (e.g. we do not take name from BytesIO() objects because they do not have it).
    A similar PR is ready for BZ2File as well (a different enhancement).

    @ellaellela ellaellela mannequin added 3.11 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Apr 4, 2022
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @serhiy-storchaka
    Copy link
    Member

    This is the part of more complex issue #115961.

    @serhiy-storchaka serhiy-storchaka closed this as not planned Won't fix, can't repro, duplicate, stale Feb 26, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.11 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    Status: Done
    Development

    No branches or pull requests

    1 participant