bpo-21622: ctypes.util find_library walk LD_LIBRARY_PATH #10460
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
…pythonGH-15647) Fixes https://bugs.python.org/issue38008 (cherry picked from commit 692a0dc) Co-authored-by: Divij Rajkumar <drajkuma1@gmail.com>
… AF_CAN. (pythonGH-14392) (pythonGH-16018) This fixes a regression from 3.5. In recent releases, `getsockname()` in the AF_CAN case has returned a string. (cherry picked from commit 954900a) Co-authored-by: bggardner <brent@ebrent.net>
…attr__ chaining so that call() can be subscriptable (pythonGH-15565) (pythonGH-15965) * bpo-37972: unittest.mock._Call now passes on __getitem__ to the __getattr__ chaining so that call() can be subscriptable * 📜🤖 Added by blurb_it. * Update 2019-08-28-21-40-12.bpo-37972.kP-n4L.rst added name of the contributor * bpo-37972: made all dunder methods chainable for _Call * bpo-37972: delegate only attributes of tuple instead to __getattr__ (cherry picked from commit 72c3599) Co-authored-by: blhsing <github@ydooby.com>
…pythonGH-16027) Prefer client or TLSv1_2 in examples Signed-off-by: Christian Heimes <christian@python.org> (cherry picked from commit 894d0f7) Co-authored-by: Christian Heimes <christian@python.org>
Does no longer work since Sphinx moved the trim_doctest_flag option in the configuration. (cherry picked from commit 2c910c1) Co-authored-by: Julien Palard <julien@palard.fr>
Signed-off-by: Christian Heimes <christian@python.org> (cherry picked from commit 64117e0) Co-authored-by: Christian Heimes <christian@python.org>
…ncy (pythonGH-11040) (cherry picked from commit 967b84c) Co-authored-by: Windson yang <wiwindson@outlook.com>
* Add a note to the PyModule_AddObject docs. * Correct example usages of PyModule_AddObject. * Whitespace. * Clean up wording. * 📜🤖 Added by blurb_it. * First code review. * Add < 0 in the tests with PyModule_AddObject (cherry picked from commit 224b8aa) Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
Signed-off-by: Christian Heimes <christian@python.org> (cherry picked from commit 5a4f82f) Co-authored-by: Christian Heimes <christian@python.org>
Three internal cpython events were not documented, yet. Signed-off-by: Christian Heimes <christian@python.org> https://bugs.python.org/issue37363 (cherry picked from commit ed4b321) Co-authored-by: Christian Heimes <christian@python.org>
(cherry picked from commit 8c74574) Co-authored-by: Christian Heimes <christian@python.org>
This is a restructuring of the datetime documentation to hopefully make
them more user-friendly and approachable to new users without losing any
of the detail.
Changes include:
- Creating dedicated subsections for some concepts such as:
- "Constants"
- "Naive vs Aware"
- "Determining if an Object is Aware"
- Give 'naive vs aware' its own subsection
- Give 'constants' their own subsection
- Overhauling the strftime-strptime section by:
- Breaking it into logical, linkable, and digestable parts
- Adding a high-level comparison table
- Moving the technical detail to bottom: readers come to this
section primarily to remind themselves to things:
- How do I write the format code for X?
- strptime/strftime: which one is which again?
- Touching up fromisoformat + isoformat sections by:
- Revising fromisoformat + isoformat for date, time, and
datetime
- Adding basic examples
- Enforcing consistency about putting formats (i.e. ``HH:MM``)
in double backticks. This was previously done in some places
but not all
- Putting long 'supported formats', on their own line to improve
readability
- Moving the 'seealso' section to the top and add a link to dateutil
Rationale: This doesn't really belong nested under the
'constants' section. Let readers know right away that
datetime is one of several related tools.
- Moving common features of several types into one place:
Previously, each type went out of its way to note separately
that it was hashable and picklable. These can be brought
into one single place that is more prominent.
- Reducing some verbose explanations to improve readability
- Breaking up long paragraphs into digestable chunks
- Displaying longer "equivalent to" examples, as short code blocks
- Using the dot notation for datetime/time classes:
Use :class:`.time` and :class:`.datetime` rather than :class:`time` and
:class:`datetime`; otherwise, the generated links will route to the
respective modules, not classes.
- Rewording the tzinfo class description
The top paragraph should get straight to the point of telling the reader
what subclasses of tzinfo _do_. Previously, that was hidden in a later
paragraph.
- Adding a note on .today() versus .now()
- Rearranging and expanding example blocks, including:
- Moved long, multiline inline examples to standalone examples
- Simplified the example block for timedelta arithmetic:
- Broke the example into two logical sections:
1. normalization/parameter 'merging'
2. timedelta arithmetic
- Reduced the complexity of the some of the examples. Show
reasonable, real-world uses cases that are easy to follow
along with and progres in difficult slightly.
- Broke up the example sections for date and datetime sections by putting
the easy examples first, progressing to more esoteric situations and
breaking it up into logical sections based on what the methods are
doing at a high level.
- Simplified the KabulTz example:
- Put the class definition itself into a non-REPL block since there is
no interactive output involved there
- Briefly explained what's happening before launching into the code
- Broke the example section into visually separate chunks
- Various whitespace, formatting, style and grammar fixes including:
- Consistently using backctics for 'date_string' formats
- Consistently using one space after periods.
- Consistently using bold for vocab terms
- Consistently using italics when referring to params:
See https://devguide.python.org/documenting/GH-id4
- Using '::' to lead into code blocks
Per https://devguide.python.org/documenting/GH-source-code, this will
let the reader use the 'expand/collapse' top-right button for REPL
blocks to hide or show the prompt.
- Using consistent captialization schemes
- Removing use of the default role
- Put 'example' blocks in Markdown subsections
This is a combination of 66 commits.
See bpo-36960: https://bugs.python.org/issue36960
(cherry picked from commit 3fb1363)
Co-authored-by: Brad <brad.solomon.1124@gmail.com>
…14048) * 1. add test case with wrong behavior * 2. fix bug when max_length == -1 * 3. allow b"" as valid input data for decompress_buf() * 4. when max_length >= 0, let needs_input mechanism works * add more asserts to test case (cherry picked from commit 4ffd05d) Co-authored-by: animalize <animalize@users.noreply.github.com>
…tamp() (pythonGH-15773) https://bugs.python.org/issue37488 Automerge-Triggered-By: @pganssle (cherry picked from commit 1a53c78) Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com>
…GH-16057) The defines are required for OpenSSL 1.0.2 and LibreSSL. https://bugs.python.org/issue38134 Automerge-Triggered-By: @tiran (cherry picked from commit 9a4963b) Co-authored-by: Christian Heimes <christian@python.org> https://bugs.python.org/issue38137 Automerge-Triggered-By: @matrixise
…ythonGH-15956) (pythonGH-16043) Test that they do not keep too many file descriptors open for the host OS in a reasonable test scenario. See [bpo-37935](https://bugs.python.org/issue37935). (cherry picked from commit f9dc2ad) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
…GH-16010) (pythonGH-16062) (cherry picked from commit 4210ad5) Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
…-15993) (pythonGH-16064) * bpo-38121: Sync importlib.metadata with 0.22 backport * 📜🤖 Added by blurb_it.. (cherry picked from commit 8ed6503) Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
Co-Authored-By: Brandt Bucher <brandtbucher@gmail.com> (cherry picked from commit b1a2abd) Co-authored-by: Hai Shi <shihai1992@gmail.com>
(cherry picked from commit 894e30c) Co-authored-by: Steve Dower <steve.dower@python.org>
FIXES bpo-21622 for 3.8
jcastillo2nd
force-pushed
the
38/bpo-21622
branch
from
97e2cfd
to
f57ac10
Compare
jcastillo2nd
requested review from
1st1,
abalkin,
asvetlov,
berkerpeksag,
brettcannon,
encukou,
ericsnowcurrently,
ericvsmith,
gpshead,
gvanrossum,
ilevkivskyi,
methane,
ncoghlan,
pganssle,
rhettinger,
terryjreedy,
tiran,
vsajip,
warsaw and
a team
as code owners
|
@jcastillo2nd , because you did a force-push after what looks like a rebase, your PR now has almost a thousand files and a bazillion reviewers, so I think it's best if you close this PR and open a new PR with just your changes. It certainly can't be reviewed as it is currently. |
|
Will do. Had forgotten this was even open and updated this to pull a build with the upstream changes.
…On Sat, Oct 26, 2019, 17:49 Vinay Sajip ***@***.***> wrote:
@jcastillo2nd <https://github.com/jcastillo2nd> , because you did a
force-push after what looks like a rebase, your PR now has almost a
thousand files and a bazillion reviewers, so I think it's best if you close
this PR and open a new PR with *just* your changes. It certainly can't be
reviewed as it is currently.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#10460?email_source=notifications&email_token=ACT67W32Z63TK3QRAVFJ5YLQQTCOLA5CNFSM4GDBVIS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECKSPNY#issuecomment-546645943>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACT67W7UZSDWF5LTJK6T6WTQQTCOLANCNFSM4GDBVISQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, issue was open for case where SONAME wasn't part of binary.
Updates to the posix case did include LD_LIBRARY_PATH, but reliance on gcc and ldconfig behavior breaks in some cases. e.g. musl on alpine builds
This provides a find method that walks the LD_LIBRARY_PATH, checks for ELF bytes, and returns the name when found or None, matching the other behavior.
This runs after all prior cases fail, does not rely on SONAME entry, gcc or ldconfig -p behavior.
https://bugs.python.org/issue21622