Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.8] bpo-37424: Avoid a hang in subprocess.run timeout output capture (GH-14490) #15897

Merged
merged 1 commit into from
Sep 11, 2019
Merged

[3.8] bpo-37424: Avoid a hang in subprocess.run timeout output capture (GH-14490) #15897

merged 1 commit into from
Sep 11, 2019

Commits on Sep 11, 2019

  1. bpo-37424: Avoid a hang in subprocess.run timeout output capture (pyt… 

    …honGH-14490)

Fixes a possible hang when using a timeout on subprocess.run() while
capturing output. If the child process spawned its own children or otherwise
connected its stdout or stderr handles with another process, we could hang
after the timeout was reached and our child was killed when attempting to read
final output from the pipes.
(cherry picked from commit 580d278)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
    @gpshead @miss-islington
    gpshead authored and miss-islington committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    07f8c42 View commit details
    Browse the repository at this point in the history