Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-31328: Add missing _sha3 module to Setup.dist #2395

Merged
merged 1 commit into from
Sep 4, 2017

Conversation

segevfiner
Copy link
Contributor

@segevfiner segevfiner commented Jun 25, 2017

@mention-bot
Copy link

@segevfiner, thanks for your PR! By analyzing the history of the files in this pull request, we identified @akuchling, @doko42 and @birkenfeld to be potential reviewers.

@merwok
Copy link
Member

merwok commented Sep 1, 2017

Hello and thanks for the patch! Could you open a ticket on bugs.python.org? It would be useful to describe the conditions in which the current code fails, and let the sha3 maintainer comment. Thanks!

@segevfiner segevfiner changed the title trivial: Add missing _sha3 module to Setup.dist bpo-31328: Add missing _sha3 module to Setup.dist Sep 1, 2017
@benjaminp benjaminp merged commit 1c1f8f3 into python:master Sep 4, 2017
segevfiner added a commit to segevfiner/cpython that referenced this pull request Sep 4, 2017
@segevfiner segevfiner deleted the patch-1 branch September 4, 2017 16:47
benjaminp pushed a commit that referenced this pull request Sep 4, 2017
jimmylai pushed a commit to jimmylai/cpython that referenced this pull request Sep 4, 2017
* 'master' of https://github.com/python/cpython: (601 commits)
  remove check for bug last seem in Solaris 9 (python#3285)
  Change code owners for hashlib and ssl to the crypto team (python#3284)
  bpo-31281: Fix pathlib.Path incompatibility in fileinput (pythongh-3208)
  remove autoconf check for select() (python#3283)
  remove configure check for 'volatile' (python#3281)
  Add missing _sha3 module to Setup.dist (python#2395)
  bpo-12383: Also ignore __PYVENV_LAUNCHER__ (python#3278)
  bpo-9146: add the missing NEWS entry. (python#3275)
  Fix a c.f.as_completed() refleak previously introduced in bpo-27144 (python#3270)
  bpo-31185: Fixed miscellaneous errors in asyncio speedup module. (python#3076)
  remove a redundant lower in urllib.parse.urlsplit (python#3008)
  bpo-31323: Fix reference leak in test_ssl (python#3263)
  bpo-31250, test_asyncio: fix EventLoopTestsMixin.tearDown() (python#3264)
  bpo-31326: ProcessPoolExecutor waits for the call queue thread (python#3265)
  bpo-27144: concurrent.futures as_complete and map iterators do not keep reference to returned object (python#1560)
  bpo-31250, test_asyncio: fix dangling threads (python#3252)
  bpo-31217: Fix regrtest -R for small integer (python#3260)
  bpo-30096: Use ABC in abc reference examples (python#1220)
  bpo-30737: Update DevGuide links to new URL (pythonGH-3228)
  [Trivial] Remove now redundant assert (python#3245)
  ...
GadgetSteve pushed a commit to GadgetSteve/cpython that referenced this pull request Sep 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants