-
-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-45138: Expand traced SQL statements in sqlite3
trace callback
#28240
Conversation
|
|
Coverage for
|
I believe I've addressed everything here, @pablogsal. Let me know if you want further changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, a few small comments
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! @gvanrossum I'm planning to merge this change, another SQLite enhancement by Erlend.
Thanks, @JelleZijlstra! |
This change broke several buildbots See https://buildbot.python.org/all/#/builders/58/builds/1850 |
I'm aware, and I'm coming up with a fix for that test. |
This reverts commit d177751.
https://bugs.python.org/issue45138