-
-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sqlite3 regression: bound values are not expanded in traced statements #89301
Comments
For SQLite 3.14.0 and newer, we're using the v2 trace API. This means that the trace callback receives a pointer to the sqlite3_stmt object. We can use the sqlite3_stmt pointer to retrieve expanded SQL string. The following statement...: ...will produce the following traces: ...instead of: |
Thanks for the contribution! |
Reopening bco. broken buildbots. |
Ah, one of my very first contributions, gh-84498, comes back to haunt me: In gh-84498, we migrated from the old SQLite trace API (sqlite3_trace) to SQLite trace v2 API (sqlite3_trace_v2). #19581, which introduced this change, introduced a bug: the old trace API _implicitly_ expanded bound parameters; the new trace API does not. However, there was no tests for this behaviour, so the regression was unnoticed1. So, this bpo is actually a bug fix; not a feature. It should be backported to 3.10, which contains the regression. I'm preparing a fix for #28240, and I'll prepare a 3.10 backport including both #19581 and its upcoming fix. Footnotes
|
…ite statements (cherry picked from commit 721aa96)
sqlite3
trace callback #28240Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: