Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed noop branch from ctypes code #3234

Merged
merged 1 commit into from
Aug 30, 2017
Merged

Removed noop branch from ctypes code #3234

merged 1 commit into from
Aug 30, 2017

Conversation

alex
Copy link
Member

@alex alex commented Aug 29, 2017

This if statement is already inside of an if _os.name == "nt". Unless I've badly misunderstood this code, this makes the second if a no-op.

@pitrou
Copy link
Member

pitrou commented Aug 30, 2017

That's probably a leftover of Windows CE compatibility code (apparently coredll is a Windows CE thing). Nice catch :-)

@pitrou pitrou merged commit cb76029 into master Aug 30, 2017
@alex alex deleted the alex-patch-1 branch August 30, 2017 11:44
GadgetSteve pushed a commit to GadgetSteve/cpython that referenced this pull request Sep 10, 2017
@alex @GadgetSteve
Removed noop branch from ctypes code (python#3234)
357d224
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alex @pitrou @Mariatta @the-knights-who-say-ni @bedevere-bot