Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44530: Document the change in MAKE_FUNCTION behavior #93189

Merged
merged 3 commits into from Jun 16, 2023
Merged

bpo-44530: Document the change in MAKE_FUNCTION behavior #93189

merged 3 commits into from Jun 16, 2023

Conversation

alexdoesh
Copy link
Contributor

Fixes dis module documentation for MAKE_FUNCTION opcode accordingly to bpo-44530, 2f180ce removes the qualified name at TOS in favor of co_qualname usage

@alexdoesh
bpo-44530: Document the change in MAKE_FUNCTION behavior
1550e47 
Fixes dis module documentation for MAKE_FUNCTION due to python@2f180ce (bpo-44530, released as part of 3.11) removes the qualified name at TOS
@cpython-cla-bot
Copy link

cpython-cla-bot bot commented May 24, 2022 •
edited

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 24, 2022
@kumaraditya303
Copy link
Contributor

Trigger CI

@kumaraditya303
Copy link
Contributor

@alexdoesh There are trailing whitespaces hence CI is failing.

@Christopher-Chianelli Christopher-Chianelli mentioned this pull request Nov 7, 2022
Closed
@stefanor
Copy link
Contributor

stefanor commented Dec 6, 2022

I just came past to file the same MR. LGTM.

@stefanor
Copy link
Contributor

stefanor commented Dec 6, 2022

I guess an update in "what's new" would be handy, too.

@williamwen42
Copy link
Contributor

What's the status on this PR? I encountered this exact issue -- MAKE_FUNCTION behavior is different than what is documented.

@Barkhat26
Copy link

Maybe, it is need to finally code review and pull this PR? Because there is the same docs error in newer python versions

@carljm
Merge branch 'main' into patch-1
cbf4dea 
* main: (3912 commits)
  pythongh-105831: Fix NEWS blurb from pythongh-105828 (python#105833)
  pythongh-105820: Fix tok_mode expression buffer in file & readline tokenizer (python#105828)
  pythongh-105751, test_ctypes: Remove disabled tests (python#105826)
  pythongh-105821: Use a raw f-string in test_httpservers.py (python#105822)
  pythongh-105751: Remove platform usage in test_ctypes (python#105819)
  pythongh-105751: Reenable disable test_ctypes tests (python#105818)
  pythongh-105751: Remove dead code in test_ctypes (python#105817)
  More reorganisation of the typing docs (python#105787)
  Improve docs for `typing.dataclass_transform` (python#105792)
  pythonGH-89812: Churn `pathlib.Path` test methods (python#105807)
  pythongh-105800: Issue SyntaxWarning in f-strings for invalid escape sequences (python#105801)
  pythongh-105751: Cleanup test_ctypes imports (python#105803)
  pythongh-105481: add HAS_JUMP flag to opcode metadata (python#105791)
  pythongh-105751: test_ctypes avoids the operator module (pythonGH-105797)
  pythongh-105751: test_ctypes: Remove @need_symbol decorator (pythonGH-105798)
  pythongh-104909: Implement conditional stack effects for macros (python#105748)
  pythongh-75905: Remove test_xmlrpc_net: skipped since 2017 (python#105796)
  pythongh-105481: Fix types and a bug for pseudos (python#105788)
  Update DSL docs for cases generator (python#105753)
  pythonGH-77273: Better bytecodes for f-strings (pythonGH-6132)
  ...
@carljm carljm merged commit 486b52a into python:main Jun 16, 2023
19 checks passed
@carljm carljm added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Jun 16, 2023
@miss-islington
Copy link
Contributor

Thanks @alexdoesh for the PR, and @carljm for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @alexdoesh for the PR, and @carljm for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @alexdoesh and @carljm, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 486b52a3158e0f64fc54efdfa34ed5437b3619f2 3.11

@miss-islington
Copy link
Contributor

Sorry @alexdoesh and @carljm, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 486b52a3158e0f64fc54efdfa34ed5437b3619f2 3.12

@carljm carljm added needs backport to 3.12 bug and security fixes and removed needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Jun 16, 2023
@miss-islington
Copy link
Contributor

Thanks @alexdoesh for the PR, and @carljm for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 16, 2023
@alexdoesh @miss-islington
bpo-44530: Document the change in MAKE_FUNCTION behavior (pythonGH-93189
c42fec2 
)

* bpo-44530: Document the change in MAKE_FUNCTION behavior

Fixes dis module documentation for MAKE_FUNCTION due to python@2f180ce (bpo-44530, released as part of 3.11) removes the qualified name at TOS
(cherry picked from commit 486b52a)

Co-authored-by: Alex Doe <alexdoesh@gmail.com>
@bedevere-bot
Copy link

GH-105841 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jun 16, 2023
@bedevere-bot
Copy link

GH-105842 is a backport of this pull request to the 3.11 branch.

carljm pushed a commit to carljm/cpython that referenced this pull request Jun 16, 2023
@alexdoesh @carljm
[3.11] bpo-44530: Document the change in MAKE_FUNCTION behavior (pyth…
3fe1112 
…onGH-93189)

* bpo-44530: Document the change in MAKE_FUNCTION behavior

Fixes dis module documentation for MAKE_FUNCTION due to python@2f180ce (bpo-44530, released as part of 3.11) removes the qualified name at TOS.
(cherry picked from commit 486b52a)

Co-authored-by: Alex Doe <alexdoesh@gmail.com>
carljm pushed a commit that referenced this pull request Jun 16, 2023
@miss-islington @alexdoesh
[3.12] bpo-44530: Document the change in MAKE_FUNCTION behavior (GH-9…
32c0aeb 
…3189) (#105841)

bpo-44530: Document the change in MAKE_FUNCTION behavior (GH-93189)

* bpo-44530: Document the change in MAKE_FUNCTION behavior

Fixes dis module documentation for MAKE_FUNCTION due to 2f180ce (bpo-44530, released as part of 3.11) removes the qualified name at TOS
(cherry picked from commit 486b52a)

Co-authored-by: Alex Doe <alexdoesh@gmail.com>
carljm added a commit that referenced this pull request Jun 16, 2023
@carljm @alexdoesh
[3.11] bpo-44530: Document the change in MAKE_FUNCTION behavior (GH-9…
7c877b5 
…3189) (#105842)

* bpo-44530: Document the change in MAKE_FUNCTION behavior

Fixes dis module documentation for MAKE_FUNCTION due to 2f180ce (bpo-44530, released as part of 3.11) removes the qualified name at TOS.
(cherry picked from commit 486b52a)

Co-authored-by: Alex Doe <alexdoesh@gmail.com>
carljm added a commit to carljm/cpython that referenced this pull request Jun 16, 2023
@carljm
Merge branch 'main' into modulelocals
b096651 
* main:
  pythongh-104799: PEP 695 backward compatibility for ast.unparse (python#105846)
  pythongh-105834: Add tests for calling `issubclass()` between two protocols (python#105835)
  CI: Remove docs build from Azure Pipelines (python#105823)
  pythongh-105844: Consistently use 'minor version' for X.Y versions (python#105851)
  Fix inaccuracies in "Assorted Topics" section of "Defining Extension Types" tutorial (python#104969)
  pythongh-105433: Add `pickle` tests for PEP695 (python#105443)
  bpo-44530: Document the change in MAKE_FUNCTION behavior (python#93189)
  pythonGH-103124: Multiline statement support for pdb (pythonGH-103125)
  pythonGH-105588: Add missing error checks to some obj2ast_* converters (pythonGH-105589)
gvanrossum pushed a commit to gvanrossum/cpython that referenced this pull request Jun 18, 2023
@alexdoesh @gvanrossum
bpo-44530: Document the change in MAKE_FUNCTION behavior (python#93189)
2b6e479 
* bpo-44530: Document the change in MAKE_FUNCTION behavior

Fixes dis module documentation for MAKE_FUNCTION due to python@2f180ce (bpo-44530, released as part of 3.11) removes the qualified name at TOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtbucher brandtbucher Awaiting requested review from brandtbucher

Assignees

@carljm carljm

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@alexdoesh @bedevere-bot @kumaraditya303 @stefanor @williamwen42 @Barkhat26 @miss-islington @carljm @AlexWaygood