New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automerge shouldn't let GH wrap the first line of the commit message #159

Closed
benjaminp opened this Issue Sep 14, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@benjaminp

benjaminp commented Sep 14, 2018

python/cpython@ee78ba2 ended up with ugly GH line-wrapping of the first line despite the PR python/cpython#2825 title being unwrapped.

@Mariatta

This comment has been minimized.

Member

Mariatta commented Sep 14, 2018

GitMate.io thinks possibly related issues are python/core-workflow#27 (Merge commit messages), #38 (Remove [X.Y] from the backport commit message), python/devguide#199 (Improve "Commit Messages" section in committing.rst), #53 (Strip backport PR number from the commit message), and python/devguide#125 (Add core-dev guidance on squash merge commit messages).

@Mariatta Mariatta added the Not a bug label Nov 11, 2018

@Mariatta

This comment has been minimized.

Member

Mariatta commented Nov 11, 2018

The line-wrapping is done by GitHub Web UI, not a bug on our side.

The git data does not break the commit message.

$ git log ee78ba2c819b0cd7671a575e584d8fe1b7adb3e4
commit ee78ba2c819b0cd7671a575e584d8fe1b7adb3e4
Author: Shoham Peller <shoham.peller@stratoscale.com>
Date:   Sat Sep 15 02:28:08 2018 +0300

    [2.7] closes bpo-8450: a better error message when http status line isn't received (GH-2825)
    
    
    
    When the server has closed the connection before sending a status-line,
    the client's error message should have a more descriptive error message
    
    https://bugs.python.org/issue8450

@Mariatta Mariatta closed this Nov 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment