Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Callable constraint inference doesn't consider argument kinds #1098

Closed
JukkaL opened this issue Dec 29, 2015 · 2 comments
Closed

Callable constraint inference doesn't consider argument kinds #1098

JukkaL opened this issue Dec 29, 2015 · 2 comments
Labels
bug mypy got something wrong priority-1-normal

Comments

@JukkaL
Copy link
Collaborator

JukkaL commented Dec 29, 2015

visit_callable_type in mypy/constraints.py should look at argument kinds and use them to match arguments. Currently it assumes that the kinds of arguments are the same in both callables.

We may be able to reuse or adapt similar code from call expression type checker (map_actuals_to_formals).

See also discussion in #1085.
@JukkaL JukkaL added the bug mypy got something wrong label Dec 29, 2015
@ddfisher ddfisher added this to the 0.4.0 milestone Mar 2, 2016
@ddfisher
Copy link
Collaborator

ddfisher commented Mar 2, 2016

Can you add a test case for this issue?

@gvanrossum gvanrossum removed this from the 0.5 milestone Mar 29, 2017
@JukkaL
Copy link
Collaborator Author

JukkaL commented May 18, 2018

Closing as duplicate of #702.

@JukkaL JukkaL closed this as completed May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug mypy got something wrong priority-1-normal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ddfisher @JukkaL @gvanrossum