Increase get_package_properties timeout #13109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some packages may take a very long time to import, which can spuriously trip the timeout in ModuleInspect. To make this less likely, increase the timeout from 5s to 30s.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
hauntsaninja
approved these changes
Jul 13, 2022
True; it would necessarily take >5s. 🙂 Thanks! |
mwoehlke-kitware
added a commit
to mwoehlke-kitware/drake
that referenced
this pull request
Jul 13, 2022
Update mypy, bringing in a patch to increase the timeout before aborting an attempt to import a module. The default timeout of 5s is not long enough to import `pydrake` in some configurations. Also increase the timeout on our `stubgen_test`. See python/mypy#13109.
mwoehlke-kitware
added a commit
to mwoehlke-kitware/drake
that referenced
this pull request
Jul 14, 2022
Update mypy, bringing in a patch to increase the timeout before aborting an attempt to import a module. The default timeout of 5s is not long enough to import `pydrake` in some configurations. Also increase the timeout on our `stubgen_test`. See python/mypy#13109.
jwnimmer-tri
pushed a commit
to RobotLocomotion/drake
that referenced
this pull request
Jul 14, 2022
Update mypy, bringing in a patch to increase the timeout before aborting an attempt to import a module. The default timeout of 5s is not long enough to import `pydrake` in some configurations. Also increase the timeout on our `stubgen_test`. See python/mypy#13109.
Gobot1234
pushed a commit
to Gobot1234/mypy
that referenced
this pull request
Aug 12, 2022
Some packages may take a very long time to import, which can spuriously trip the timeout in ModuleInspect. To make this less likely, increase the timeout from 5s to 30s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some packages may take a very long time to import, which can spuriously trip the timeout in
ModuleInspect. To make this less likely, increase the timeout from 5s to 30s.Test Plan
I could use some help with how to write an appropriate test, as it doesn't seem to obviously match any existing tests (somewhat pep561.test though it's unclear how that handles the test package). I think the general idea is to write a test that simply tries to inspect a test package whose
__init__.pylooks like:This works to reproduce the failure by attempting to run
stubgenon the above.An example of this failure occurring "in the wild" can be seen here.