Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two out-of-bounds array reads #99

Merged
merged 1 commit into from Apr 9, 2019
Merged

Conversation

@wictory
Copy link
Contributor

@wictory wictory commented Apr 5, 2019

The patch is taken from a commit to the CPython repo with the message:

bpo-36495: Fix two out-of-bounds array reads (GH-12641)

Research and fix by @bradlarsen.

Some code I have triggered segmentation fault when I run pylint on it. With this patch, I don't get segmentation fault anylonger.

Backtrace from GDB:
#0 0x00001ff4e48a883b in ast_for_arguments () from $HOME/.local/lib/python3.6/site-packages/typed_ast/_ast3.so
#1 0x00001ff4e48ac4c0 in ast_for_funcdef_impl () from $HOME/.local/lib/python3.6/site-packages/typed_ast/_ast3.so
#2 0x00001ff4e48ac315 in ast_for_suite () from $HOME/.local/lib/python3.6/site-packages/typed_ast/_ast3.so
#3 0x00001ff4e48abd1e in ast_for_classdef () from $HOME/.local/lib/python3.6/site-packages/typed_ast/_ast3.so
#4 0x00001ff4e48a22c7 in Ta3AST_FromNodeObject () from $HOME/.local/lib/python3.6/site-packages/typed_ast/_ast3.so
#5 0x00001ff4e48c4f93 in ast3_parse () from $HOME/.local/lib/python3.6/site-packages/typed_ast/_ast3.so
#6 0x00001ff550af508a in _PyCFunction_FastCallDict () from /usr/local/lib/libpython3.6m.so.0.0
#7 0x00001ff550b86798 in call_function () from /usr/local/lib/libpython3.6m.so.0.0
#8 0x00001ff550b80c0e in _PyEval_EvalFrameDefault () from /usr/local/lib/libpython3.6m.so.0.0
#9 0x00001ff550b87168 in _PyEval_EvalCodeWithName () from /usr/local/lib/libpython3.6m.so.0.0
#10 0x00001ff550b88081 in _PyFunction_FastCallDict () from /usr/local/lib/libpython3.6m.so.0.0
#11 0x00001ff550a9dd3d in _PyObject_FastCallDict () from /usr/local/lib/libpython3.6m.so.0.0
#12 0x00001ff550bf8f76 in partial_call () from /usr/local/lib/libpython3.6m.so.0.0
#13 0x00001ff550a9ddea in _PyObject_FastCallDict () from /usr/local/lib/libpython3.6m.so.0.0
#14 0x00001ff550b86765 in call_function () from /usr/local/lib/libpython3.6m.so.0.0
#15 0x00001ff550b80c0e in _PyEval_EvalFrameDefault () from /usr/local/lib/libpython3.6m.so.0.0
#16 0x00001ff550b87168 in _PyEval_EvalCodeWithName () from /usr/local/lib/libpython3.6m.so.0.0
#17 0x00001ff550b87cbb in fast_function () from /usr/local/lib/libpython3.6m.so.0.0
#18 0x00001ff550b8676c in call_function () from /usr/local/lib/libpython3.6m.so.0.0
#19 0x00001ff550b80c0e in _PyEval_EvalFrameDefault () from /usr/local/lib/libpython3.6m.so.0.0
#20 0x00001ff550b87d46 in fast_function () from /usr/local/lib/libpython3.6m.so.0.0
#21 0x00001ff550b8676c in call_function () from /usr/local/lib/libpython3.6m.so.0.0
#22 0x00001ff550b80c0e in _PyEval_EvalFrameDefault () from /usr/local/lib/libpython3.6m.so.0.0
#23 0x00001ff550b87168 in _PyEval_EvalCodeWithName () from /usr/local/lib/libpython3.6m.so.0.0
#24 0x00001ff550b87cbb in fast_function () from /usr/local/lib/libpython3.6m.so.0.0
#25 0x00001ff550b8676c in call_function () from /usr/local/lib/libpython3.6m.so.0.0
#26 0x00001ff550b80c0e in _PyEval_EvalFrameDefault () from /usr/local/lib/libpython3.6m.so.0.0
#27 0x00001ff550b87168 in _PyEval_EvalCodeWithName () from /usr/local/lib/libpython3.6m.so.0.0
#28 0x00001ff550b87cbb in fast_function () from /usr/local/lib/libpython3.6m.so.0.0
#29 0x00001ff550b8676c in call_function () from /usr/local/lib/libpython3.6m.so.0.0
#30 0x00001ff550b835c9 in _PyEval_EvalFrameDefault () from /usr/local/lib/libpython3.6m.so.0.0
#31 0x00001ff550b87168 in _PyEval_EvalCodeWithName () from /usr/local/lib/libpython3.6m.so.0.0
#32 0x00001ff550b87cbb in fast_function () from /usr/local/lib/libpython3.6m.so.0.0
#33 0x00001ff550b8676c in call_function () from /usr/local/lib/libpython3.6m.so.0.0
#34 0x00001ff550b80c0e in _PyEval_EvalFrameDefault () from /usr/local/lib/libpython3.6m.so.0.0
#35 0x00001ff550b87168 in _PyEval_EvalCodeWithName () from /usr/local/lib/libpython3.6m.so.0.0
#36 0x00001ff550b87cbb in fast_function () from /usr/local/lib/libpython3.6m.so.0.0
#37 0x00001ff550b8676c in call_function () from /usr/local/lib/libpython3.6m.so.0.0
#38 0x00001ff550b835c9 in _PyEval_EvalFrameDefault () from /usr/local/lib/libpython3.6m.so.0.0
#39 0x00001ff550b87168 in _PyEval_EvalCodeWithName () from /usr/local/lib/libpython3.6m.so.0.0

The patch is taken from a commit to the CPython repo with the message:

bpo-36495: Fix two out-of-bounds array reads (GH-12641)

Research and fix by @bradlarsen.
@the-knights-who-say-ni
Copy link

@the-knights-who-say-ni the-knights-who-say-ni commented Apr 5, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

Loading

@gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented Apr 5, 2019

Thanks! Are you planning to sign the CLA? If not, I'll treat this as a bug report and apply the fix myself.

Loading

@wictory
Copy link
Contributor Author

@wictory wictory commented Apr 6, 2019

@gvanrossum I signed the agreement now, but apparently it may take one business day for it to show up on github.

Loading

@gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented Apr 6, 2019

OK, once the CLA bot changes the label I'll merge this. Thanks for your contribution!

Loading

@gvanrossum gvanrossum merged commit dc317ac into python:master Apr 9, 2019
2 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants