Change names of ast* modules

[ddfisher]

Instead of adding a new ast3x module for every new Python version, we're now planning on updating the ast35 module with the Python changes. Accordingly, the ast27 and ast35 modules should probably be renamed to ast2 and ast3, respectively.

[ddfisher]

ast35 has been renamed ast3 as part of the Python 3.6 rebuild.

[gvanrossum]

Let's decide whether we want to rename ast27 -> ast2 as well, or whether we'll stick with that -- in the latter case we can close this issue.

[ambv]

FYI, currently the source tarball of 1.0.1 contains both ast2.py and ast27.py which makes the bundled tests fail (there's no _ast2, just _ast27).

[ddfisher]

That's unfortunate. Will PyPI let me upload a fixed sdist if I remove the old one?

[ambv]

Not a .tar.gz. Fortunately, there's a trick.

1. Go to PyPI and delete the .tar.gz.
2. Build and upload a .zip:

python3 setup.py sdist --formats=zip upload

[ambv]

Oh, and FWIW my opinion on the matter is to leave the name "ast27", unless GvR is secretly planning to release 2.8 ;) The point of "ast3" is forward-compatibility, not backwards-compatibility, right?

[gvanrossum]

Well we did move the typeshed subdirs to 2 (from 2.7) to save typing and for consistency with 3.

…

--Guido (mobile)

On Feb 22, 2017 4:29 PM, "Łukasz Langa" ***@***.***> wrote: Oh, and FWIW my opinion on the matter is to leave the name "ast27", unless GvR is secretly planning to release 2.8 ;) The point of "ast3" is forward-compatibility, not backwards-compatibility, right? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#18 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACwrMh0WsS7Gs0nKSHjKY-lWCGpNZMjyks5rfO8EgaJpZM4KIR0e> .

[ddfisher]

@ambv: Fixed using that trick, thanks.

[keszybz]

When changing the names of the modules, please consider moving them out the common namespace, i.e. moving them to typed_ast._ast3, typed_ast._ast2. "Polluting" the global namespace is not nice and raises the chances of conflict in the future.

[msullivan]

This happened a while ago

[gvanrossum]

When changing the names of the modules, please consider moving them out the common namespace, i.e. moving them to typed_ast._ast3, typed_ast._ast2. "Polluting" the global namespace is not nice and raises the chances of conflict in the future.

Note that this hasn't happened yet -- IIUC this is asking to rename the extension modules from toplevel _ast27 and _ast3 into the typed_ast namespace. I think that's possible though I don't recall how. It would need a separate issue though.