Fixes collisions(#1183). #1666
Merged
Fixes collisions(#1183). #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, if min_a, min_b, max_a, max_b weren't changed by the code, it would break(make odd collisions) as #1183 notes. Now, it always creates the collisions
|
Thank you! |
|
Do we have some sample data of some hit box points that triggered this issue? It would be useful adding this to unit tests so we can cover future implementations including the rust version. |
gran4
pushed a commit
to gran4/arcade
that referenced
this pull request
Apr 2, 2023
Tests are_polygons_intersecting
checks if both are empty
checks if one is empty one is not.
As the bellow note
pythonarcade#1183
pythonarcade#1666
gran4
pushed a commit
to gran4/arcade
that referenced
this pull request
Apr 3, 2023
New PR Made tests for pythonarcade#1666
Merged
Cleptomania
pushed a commit
that referenced
this pull request
Apr 3, 2023
* Fixed Geometry tests New PR Made tests for #1666 * Made a mistake(Fixed) * Fixed v2 --------- Co-authored-by: Grant Hur <22hurg@sjchrisitan.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, if min_a, min_b, max_a, max_b weren't changed by the code, it would break(make odd collisions) as #1183 notes. Now, it always creates the collisions