Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sprite & SpriteList programming guide pages #1691

Merged
merged 15 commits into from
Apr 30, 2023
Merged

Add Sprite & SpriteList programming guide pages #1691

merged 15 commits into from
Apr 30, 2023

Conversation

pushfoo
Copy link
Member

@pushfoo pushfoo commented Apr 8, 2023 •
edited
Loading

Stacks onto #1724; second PR split from #1620.

Changes

Adds a structure similar to the one outlined in #1194, consisting of:

  • A landing page for sprites & drawing topics in the programming guide
  • An overview of Sprite & SpriteList concepts
  • A bare minimum drawing example
  • An advanced techniques page
  • Links to the new pages from the programming guide & front page indices

How to test

  1. Clone the branch
  2. Run python make.py serve
  3. Navigate to the new pages in your browser

@pushfoo pushfoo mentioned this pull request Apr 8, 2023
Draft
4 tasks
pvcraven
pvcraven requested changes Apr 8, 2023
View reviewed changes
Copy link
Member

@pvcraven pvcraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

doc/example_code/how_to_examples/index.rst Show resolved Hide resolved
doc/programming_guide/sprites/index.rst Outdated Show resolved Hide resolved
doc/programming_guide/sprites/spritelists.rst Outdated Show resolved Hide resolved
doc/programming_guide/sprites/spritelists.rst Outdated Show resolved Hide resolved
@pushfoo pushfoo mentioned this pull request Apr 11, 2023
Closed
@pushfoo pushfoo marked this pull request as ready for review April 11, 2023 18:26
@pushfoo pushfoo requested a review from pvcraven April 11, 2023 18:52
@pushfoo pushfoo force-pushed the add_spritelist_programming_guide_page branch from ac86051 to 6cb0ccc Compare April 24, 2023 21:06
@pushfoo pushfoo mentioned this pull request Apr 25, 2023
Merged
@pushfoo pushfoo force-pushed the add_spritelist_programming_guide_page branch from 6cb0ccc to 69188f6 Compare April 25, 2023 01:58
@pvcraven pvcraven merged commit 9d8d736 into pythonarcade:development Apr 30, 2023
@pushfoo pushfoo deleted the add_spritelist_programming_guide_page branch May 7, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gran4 gran4 gran4 left review comments

@pvcraven pvcraven pvcraven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pushfoo @pvcraven @gran4