Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style follow-up to #1681 #1715

Merged
merged 4 commits into from
Apr 24, 2023

Conversation

pushfoo
Copy link
Member

@pushfoo pushfoo commented Apr 24, 2023

Follows upon #1681 with some minor styling tweaks as mentioned in the comments .

Ty to Clepto for already grabbing some of the lingering styling issues!

@pushfoo pushfoo changed the title Style follow-up to 1681 Style follow-up to #1681 Apr 24, 2023
@Cleptomania
Copy link
Member

Is this ready to go or is there more to fix here?

@pushfoo
Copy link
Member Author

pushfoo commented Apr 24, 2023

tl;dr Yes

The main thing I wanted to address is was this indent:

arcade/arcade/text.py

Lines 15 to 19 in 26d05eb

__all__ = ["load_font",
"Text",
"create_text_sprite",
"draw_text"
]

The rest is spacing / ordering that's fairly inconsistent across the repo anyway, such as:

  • LOG / __all__ / etc ordering
  • Spacing style

I'll hold off on homogenizing top-of-file style beyond the bare minimum until we have time to discuss & add a more detailed style guide section for the Programming/Contributing Guide.

@Cleptomania
Copy link
Member

I'll hold off on homogenizing top-of-file style beyond the bare minimum until we have time to discuss & add a more detailed style guide section for the Programming/Contributing Guide.

This is probably better suited as a discussion about using an auto-formatter(like black), but I agree that can be handled separately.

@Cleptomania Cleptomania merged commit f4a959f into pythonarcade:development Apr 24, 2023
5 checks passed
@pushfoo
Copy link
Member Author

pushfoo commented Apr 24, 2023

Using an auto-formatter(like black)

This may be why whitespace linting isn't enabled on ruff by default.

@pushfoo pushfoo deleted the follow_up_to_1681 branch April 24, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants