Added all to many files #1681

gran4 · 2023-04-05T01:34:46Z

Attempts to fix #1390.
Its unlikely to be perfect yet. I expect a bunch of tests to break

Fixes pythonarcade#1390

…to add__all__to_all

gran4 · 2023-04-05T01:55:47Z

This does it say "arcade.scene.Scene.draw:9:Unexpected indentation". I don't see anything

einarf · 2023-04-05T12:01:22Z

This does it say "arcade.scene.Scene.draw:9:Unexpected indentation". I don't see anything

Revert your changes to the docstrings in Scene. You removed a lot of empty newlines. They are there for a reason. Especially the newline between the decription text and the parameter list. There are fairly strict rules on how rst docstrings should be formatted.

Also, your PR is about adding __all__ to many modules. Ideally this should also not contain something random like changing docstrings.

arcade/scene.py

gran4 · 2023-04-05T15:42:56Z

I don't remember touching them. One of my extensions did that or something.

…to add__all__to_all

arcade/draw_commands.py

arcade/math.py

arcade/paths.py

arcade/physics_engines.py

arcade/perf_info.py

arcade/shape_list.py

arcade/sprite/sprite.py

arcade/text.py

arcade/tilemap/tilemap.py

arcade/version.py

gran4 · 2023-04-07T00:41:54Z

I must have some weird extension. I copy pasted it from arcade bc I messed with it, yet still wanted to commit the file. What should I do? I just deleted it for now.

einarf · 2023-04-07T18:10:24Z

I must have some weird extension. I copy pasted it from arcade bc I messed with it, yet still wanted to commit the file. What should I do? I just deleted it for now.

Probably just undo the changes. No need to start from scratch. We squash all the commits anyway so it's not a problem with lots of ugly ones.

einarf · 2023-04-08T20:05:33Z

Can you just copy scene.py from development branch and replace it with your current one? Add in the __all__ after.

These space changes are so distruptive to git history.

Double check that your own development branch has not diverged from arcade's development branch.

gran4 · 2023-04-14T21:06:27Z

@einarf I'll make a separate pull request

pushfoo

There are still extra indents in scene.py, and there are some additional changes that may need to be made.

The linting step should have picked up those extra spaces, and we should investigate why it isn't doing that as a separate issue (#1701).

arcade/application.py

arcade/hitbox/base.py

arcade/physics_engines.py

arcade/scene.py

Co-authored-by: Paul <36696816+pushfoo@users.noreply.github.com>

…to add__all__to_all

pushfoo · 2023-04-20T16:46:40Z

You can probably close #1700 since it's redundant now.

cspotcode

This is a huge improvement, thank you. I think it's suitable to merge.

I did some testing. This does not fix every single __all__ issue, so we should keep #1390 open. I'll share on #1390 how we can use mypy to find the remaining __all__ issues and fix them in a subsequent PR.

pushfoo

I'll follow up on some of the minor lingering style issues after we merge this.

OP has already been through a lot, including helping us discover that our ruff config didn't have whitespace checking enabled (#1701). My guess is their editor or IDE was maintaining previous indent level rather than intelligently managing blank lines. It's an understandable difficulty for a beginner.

Lingering style issues will be fixed in a second PR

* Make text.py's __all__ consistent with style used in the rest of the codebase * Fix top of module whitespace in perf_graph.py * Make pymunk_physics_engine.py consisten with the project's __all__ style * Tweak spacing

Grant Hur and others added 6 commits April 4, 2023 18:35

Added __all__ to many files

f4a012b

Fixes pythonarcade#1390

Again added __all__ to many files

ab519c1

Fixes pythonarcade#1390

Shouldn't conflict

5aaeda5

Merge branch 'development' into add__all__to_all

cc687e6

Should fix tests failing

b54ae24

Merge branch 'add__all__to_all' of https://github.com/gran4/arcade in…

5ac2231

…to add__all__to_all