Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump min pyglet to 2.0.6 for RGBA caret support #1744

Merged
merged 1 commit into from
May 5, 2023

Conversation

pushfoo
Copy link
Member

@pushfoo pushfoo commented May 2, 2023

Changes

  • Bump the minimum pyglet version to 2.0.6 so we can guarantee RGBA caret support in labels

How to test

  1. pytest tests/unit as usual
  2. Run sound examples locally?

I've held off on further action on #1690 until pyglet shipped pyglet/pyglet#806.

Potential Issue

The one potential issue with this PR is an ignored exception related to OpenAL:

============================= 558 passed, 2 xfailed, 2 warnings in 13.40s ==============================
Exception ignored in: <function OpenALDriver.__del__ at 0x7fabdc82bc10>
Traceback (most recent call last):
  File "/home/user/src/arcade/.venv/lib/python3.9/site-packages/pyglet/media/drivers/openal/adaptation.py", line 27, in __del__
    self.delete()
  File "/home/user/src/arcade/.venv/lib/python3.9/site-packages/pyglet/media/drivers/openal/adaptation.py", line 34, in delete
    self.worker.stop()
  File "/home/user/src/arcade/.venv/lib/python3.9/site-packages/pyglet/media/mediathreads.py", line 59, in stop
    self._thread.join()
  File "/usr/lib/python3.9/threading.py", line 1030, in join
    raise RuntimeError("cannot join current thread")
RuntimeError: cannot join current thread

System info:

$ python -m arcade

Arcade 3.0.0.dev21
------------------
vendor: Intel
renderer: Mesa Intel(R) UHD Graphics 620 (KBL GT2)
version: (4, 6)
python: 3.9.2 (default, Feb 28 2021, 17:03:44) 
[GCC 10.2.1 20210110]
platform: linux
pyglet version: 2.0.6
PIL version: 9.4.0

@pushfoo pushfoo changed the title Update to pyglet 2.0.6 to guarantee RGBA caret support Bump min pyglet 2.0.6 to ensure RGBA caret support May 2, 2023
@pushfoo pushfoo changed the title Bump min pyglet 2.0.6 to ensure RGBA caret support Bump min pyglet to 2.0.6 for RGBA caret support May 2, 2023
@pushfoo pushfoo marked this pull request as draft May 3, 2023 06:21
@pushfoo
Copy link
Member Author

pushfoo commented May 3, 2023

There may be an issue with text under pyglet 2.0.6 on Linux. I'm converting this into a draft until the issue is investigated further.

@pushfoo pushfoo marked this pull request as ready for review May 3, 2023 07:09
@pushfoo
Copy link
Member Author

pushfoo commented May 3, 2023

tl;dr the issue (pyglet/pyglet#823) doesn't seem to affect arcade's text, but we may want to hold off on further use of pyglet shapes

  1. We seem to be unaffected by the issue because our text widgets do not use pyglet.gui.widgets.TextEntry, nor do they use Pyglet's shapes much directly
  2. The issue has been present since shortly after pyglet 2.0.2 (pyglet commit hash 44da1724539823ac)
  3. A user on the pyglet Discord is investigating it further

@einarf einarf merged commit 37ba31f into pythonarcade:development May 5, 2023
5 checks passed
@pushfoo pushfoo deleted the bump_pyglet_to_2.0.6 branch May 7, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants