Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unprotect _EMPTY_POINT_LIST & move it to arcade.types #1792

Merged
merged 1 commit into from
May 29, 2023
Merged

Unprotect _EMPTY_POINT_LIST & move it to arcade.types #1792

merged 1 commit into from
May 29, 2023

Conversation

pushfoo
Copy link
Member

@pushfoo pushfoo commented May 22, 2023

Changes

  1. Unprotect _EMPTY_POINT_LIST by renaming it to EMPTY_POINT_LIST
  2. Move it next to the PointList declaration.

Why

This utility constant isn't specific to hitboxes, so it makes more sense to keep it next to the original type alias declaration.

@pushfoo pushfoo mentioned this pull request May 22, 2023
Merged
@pvcraven pvcraven merged commit d58d998 into pythonarcade:development May 29, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvcraven pvcraven pvcraven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pushfoo @pvcraven