Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pyright issues in pathing #1809

Merged

Conversation

pushfoo
Copy link
Member

@pushfoo pushfoo commented Jun 4, 2023

Follow-up to #1762

Changes

  • Cast a return type to silence a pyright error
  • Use #type: ignore on a short-circuit evaluation pyright fails to understand

Follow-up work

The UI stack needs similar fixes, but I do not yet understand the intended design well enough to be confident fixing it.

@eruvanos eruvanos merged commit 8c5fde5 into pythonarcade:development Jun 5, 2023
6 checks passed
@pushfoo pushfoo deleted the fix_pyright_issues_in_pathing branch June 5, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants