-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs to paths.py #1762
Add docs to paths.py #1762
Conversation
get_vertex_neighbours seems inefficient. |
Should I add slots? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I am unsure about the usage of google docs style, but I also filed a request in discord.
I would be fine with the change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tl;dr
- Some of these changes are good
- However, there are typos in the PR
- We should wait on using Google style docstrings since it can break rendering
On Google docstrings
I've experimented with enabling Google docstrings locally & asked about next steps. I agree with einarf's recommendation that we should do the following:
- Stick to our current docstring format for now
- Use a conversion script to update docstrings in a dedicated PR when we're ready
get_vertex_neighbors
get_vertex_neighbours seems inefficient.
I agree there's room for some small optimizations here. However:
- That would be oustide the scope of a doc-focused PR
- The best approach to pathfinding is offloading it to non-Python code such as Rust or C++
Should I add __slots__
?
Probably not in this PR, and I'm not sure about doing so in general. I think our pathfinding code is worth considering for refactoring in general, but it needs some careful consideration on how to do it right. It could be better to put a warning label on it and say that it's a suboptimal prototyping tool, but I'm not yet sure.
Co-authored-by: Paul <36696816+pushfoo@users.noreply.github.com>
Co-authored-by: Paul <36696816+pushfoo@users.noreply.github.com>
Well, I was asking: not for this PR put in general. I'll change it to use the other style. |
Co-authored-by: Paul <36696816+pushfoo@users.noreply.github.com>
There are still some unresolved conversation here. What is the status on that? |
@einarf sorry for the delay. I have been busy with finals, but school is over so I have time now. The PR is ready for review. |
No description provided.