Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish #1845 : Move Background classes to experimental #1890

Merged
merged 4 commits into from
Sep 11, 2023
Merged

Finish #1845 : Move Background classes to experimental #1890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
891711b
Move backgrounds to experimental module
pushfoo Sep 7, 2023
edf6367
Update imports + __all__ for background move
pushfoo Sep 7, 2023
ededc03
Update imports in background example code
pushfoo Sep 7, 2023
6a4c8b2
Add experimental warning to background parallax RST
pushfoo Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion arcade/examples/background_blending.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
from __future__ import annotations

import arcade
import arcade.background as background
import arcade.experimental.background as background

SCREEN_WIDTH = 800
SCREEN_HEIGHT = 600
Expand Down
2 changes: 1 addition & 1 deletion arcade/examples/background_groups.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
from __future__ import annotations

import arcade
import arcade.background as background
import arcade.experimental.background as background

SCREEN_WIDTH = 800
SCREEN_HEIGHT = 600
Expand Down
2 changes: 1 addition & 1 deletion arcade/examples/background_parallax.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
from __future__ import annotations

import arcade
import arcade.background as background
import arcade.experimental.background as background


SCREEN_TITLE = "Background Group Example"
Expand Down
2 changes: 1 addition & 1 deletion arcade/examples/background_scrolling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
from __future__ import annotations

import arcade
import arcade.background as background
import arcade.experimental.background as background

SCREEN_WIDTH = 800
SCREEN_HEIGHT = 600
Expand Down
2 changes: 1 addition & 1 deletion arcade/examples/background_stationary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
from __future__ import annotations

import arcade
import arcade.background as background
import arcade.experimental.background as background

SCREEN_WIDTH = 800
SCREEN_HEIGHT = 600
Expand Down
16 changes: 16 additions & 0 deletions arcade/experimental/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,15 @@
from .shadertoy import Shadertoy, ShadertoyBuffer, ShadertoyBase
from .crt_filter import CRTFilter
from .bloom_filter import BloomFilter
from .background import (
Background,
BackgroundGroup,
ParallaxGroup,
BackgroundTexture,
texture_from_file,
background_from_file
)


__all__ = [
"VideoPlayer",
Expand All @@ -18,8 +27,15 @@
"ShadertoyBase",
"CRTFilter",
"BloomFilter",
"Background",
"BackgroundGroup",
"ParallaxGroup",
"BackgroundTexture",
"texture_from_file",
"background_from_file"
]


# Keep cv2 an optional dependency
try:
from .video_cv2 import CV2PlayerView, VideoPlayerCV2 # noqa: F401
Expand Down
6 changes: 3 additions & 3 deletions arcade/background/__init__.py → arcade/experimental/background/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
from arcade import get_window
from arcade.resources import resolve

from arcade.background.background_texture import BackgroundTexture
from arcade.background.background import Background
from arcade.background.groups import BackgroundGroup, ParallaxGroup
from arcade.experimental.background.background_texture import BackgroundTexture
from arcade.experimental.background.background import Background
from arcade.experimental.background.groups import BackgroundGroup, ParallaxGroup

__all__ = [
"Background",
Expand Down
2 changes: 1 addition & 1 deletion arcade/background/background.py → arcade/experimental/background/background.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from arcade.window_commands import get_window
import arcade.gl as gl

from arcade.background import BackgroundTexture
from arcade.experimental.background import BackgroundTexture


class Background:
Expand Down
0 arcade/background/background_texture.py → ...rimental/background/background_texture.py
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion arcade/background/groups.py → arcade/experimental/background/groups.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from typing import Optional, Union, List, Tuple

import arcade.gl as gl
from arcade.background import Background
from arcade.experimental.background import Background


class BackgroundGroup:
Expand Down
5 changes: 5 additions & 0 deletions doc/example_code/how_to_examples/background_parallax.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@
Parallax
========

.. warning:: This example is experimental!

The features it uses may change rapidly or be replaced in
future arcade releases!

.. image:: background_parallax.png
:width: 600px
:align: center
Expand Down
Loading