Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish #1845 : Move Background classes to experimental #1890

Merged

Conversation

pushfoo
Copy link
Member

@pushfoo pushfoo commented Sep 7, 2023

Changes

Closes #1845

  1. Move the arcade.background module to arcade.experimental.background
  2. Update imports
  3. Add items to __all__ in experimental/init.py`
  4. Add an experimental warning to the top of doc/example_code/how_to_examples/background_parallax.rst

Steps to test

I've run the following locally.

Doc

  1. pip install -I -e .[dev]
  2. ./make.py clean
  3. ./make.py serve
  4. Open http://localhost:8000/example_code/how_to_examples/background_parallax.html
  5. Verify a warning has been added, located:
    1. Beneath the title

    2. Above the image

      image

Example code:

Run the following example files in arcade/examples:

  1. background_blending.py
  2. background_groups.py
  3. background_parallax.py
  4. background_scrolling.py
  5. background_stationary.py

@pushfoo pushfoo force-pushed the 1845_BackgroundTexture-experimental branch from fd72935 to 6a4c8b2 Compare September 11, 2023 08:40
@einarf einarf merged commit d34f950 into pythonarcade:development Sep 11, 2023
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move BackgroundTexture to experimental
2 participants