Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to pyglet 2.0.12 + update doc and pyglet TextLayout method names #1942

Merged

Conversation

pushfoo
Copy link
Member

@pushfoo pushfoo commented Dec 15, 2023

Changes

  • Bump minimum pyglet to 2.0.12
  • Update _get_left and similar to pyglet.layout.TextLayout's new left, right, and similar bound properties
  • Fix create_text_sprite by using None as the default width
  • Remove mention of a PulseAudio bug fixed in 2.0.11

Testing steps taken

Platform independent

  • Build and preview the docs locally

OSes + Python versions Tested

  • Linux (Debian 11) with Python 3.9.2, 3.12.0
    • Compare text drawing examples between development and this branch
    • Run GUI examples and compare for breakage
  • Mac
    • Compare text drawing examples between development and this branch
    • Run GUI examples and compare for breakage
  • Windows
    • Compare text drawing examples between development and this branch
    • Run GUI examples and compare for breakage

@pushfoo pushfoo marked this pull request as draft December 16, 2023 03:09
@pushfoo
Copy link
Member Author

pushfoo commented Dec 16, 2023

I've marked this as a draft for now since the PulseAudio fixes didn't actually make it into pyglet's 2.0.10 release.

@eruvanos
Copy link
Member

Wait for pyglet to release 2.0.11 and bump required version within arcade

@pushfoo
Copy link
Member Author

pushfoo commented Feb 27, 2024

Update on this:

  1. We aren't ready to merge yet because pyglet hasn't released 2.0.11
  2. We're close because pyglet/203c5b6 is labeled as getting ready for that release

@DigiDuncan
Copy link
Collaborator

Pyglet's out.

@pushfoo pushfoo marked this pull request as ready for review February 28, 2024 06:12
@pushfoo pushfoo changed the title Remove mention of pyglet's PulseAudio bug Bump to pyglet 2.0.11 Feb 28, 2024
@pushfoo pushfoo force-pushed the remove_pulseaudio_bug_mention branch from 6e6db1c to a4009c5 Compare February 28, 2024 06:16
@pushfoo pushfoo changed the title Bump to pyglet 2.0.11 Bump to pyglet 2.0.11 + remove PulseAudio bug warning Feb 28, 2024
@pushfoo pushfoo force-pushed the remove_pulseaudio_bug_mention branch from a4009c5 to 9afc558 Compare February 28, 2024 06:22
@pushfoo
Copy link
Member Author

pushfoo commented Feb 28, 2024

I fixed the build failures. They were due to pyglet.layout.TextLayout appending _anchor to its _get_* anchor methods in 2.0.11.

The build failures may be related to 2.0.11's changes to pyglet's Label class or its dependencies. I'm investigating.

@pushfoo pushfoo changed the title Bump to pyglet 2.0.11 + remove PulseAudio bug warning Bump to pyglet 2.0.11 + update doc and pyglet TextLayout method names Feb 28, 2024
@caffeinepills
Copy link

caffeinepills commented Feb 28, 2024

Left, right, bottom, top properties exist on the TextLayouts themselves now (as of 2.0.11). You should use those instead as the anchors no longer factor in the position of the layout.

pyproject.toml Outdated Show resolved Hide resolved
arcade/text.py Outdated Show resolved Hide resolved
@pushfoo pushfoo force-pushed the remove_pulseaudio_bug_mention branch from 0a5b699 to 01fe065 Compare February 29, 2024 16:21
@pushfoo pushfoo changed the title Bump to pyglet 2.0.11 + update doc and pyglet TextLayout method names Bump to pyglet 2.0.12 + update doc and pyglet TextLayout method names Feb 29, 2024
@einarf einarf merged commit 58884ea into pythonarcade:development Feb 29, 2024
7 checks passed
@pushfoo pushfoo deleted the remove_pulseaudio_bug_mention branch February 29, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants