GUI: finish public api of arcade.gui.property #2014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for simple callbacks)
pushfoo
suggested changes
Mar 4, 2024
Co-authored-by: Paul <36696816+pushfoo@users.noreply.github.com>
pushfoo
suggested changes
Mar 4, 2024
|
TL;DR: After fixing my suggestion typo, merge as-is if you or einarf think it's fine I'm not yet sure on the type annotations for this. My instinct is that there is something we can do to polish it, but I may also be wrong. Getting it merged and working takes priority over perfect types, however. It's not breaking anything else as far as I can tell, and the stricter type checkers aren't something we're in full compliance with yet anyway. |
Co-authored-by: Paul <36696816+pushfoo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
properties provide instance and value to listener (keep support for simple callbacks)