Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GUI ellipsis type issues with mypy 1.9.0 / pyright #2018

Closed
wants to merge 2 commits into from
Closed

Fix GUI ellipsis type issues with mypy 1.9.0 / pyright #2018

wants to merge 2 commits into from

Conversation

pushfoo
Copy link
Member

@pushfoo pushfoo commented Mar 12, 2024 •
edited
Loading

Changes

  • Replace ellipsis with Optional + None syntax

@pushfoo pushfoo changed the title Fix GUI type issues with mypy 1.9.0 / pyright Fix GUI ellipsis type issues with mypy 1.9.0 / pyright Mar 13, 2024
@pushfoo pushfoo mentioned this pull request Mar 13, 2024
Merged
@eruvanos
Copy link
Member

eruvanos commented Mar 13, 2024 •
edited
Loading

I see it appears in Python >= 2.10 -.-

Maybe there is a way to fix that type hints for the background.

@eruvanos
Copy link
Member

Fixed with #2014 , thanks for your code, I took the padding changes

@eruvanos eruvanos closed this Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pushfoo @eruvanos