Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: make the clafrica more modular #99

Merged
merged 2 commits into from
Oct 18, 2023
Merged

refactor: make the clafrica more modular #99

merged 2 commits into from
Oct 18, 2023

Conversation

pythonbrad
Copy link
Collaborator

@pythonbrad pythonbrad commented Oct 18, 2023 •
edited
Loading

linked to #96

@pythonbrad pythonbrad self-assigned this Oct 18, 2023
@coveralls
Copy link

coveralls commented Oct 18, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6555320572

  • 726 of 739 (98.24%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.9%) to 98.557%
Changes Missing Coverage Covered Lines Changed/Added Lines %
engine/preprocessor/src/lib.rs 324 327 99.08%
service/src/convert.rs 27 37 72.97%
Totals Coverage Status
Change from base Build 6380518376: -0.9%
Covered Lines: 1229
Relevant Lines: 1247
💛 - Coveralls

@pythonbrad pythonbrad marked this pull request as ready for review October 18, 2023 03:08
@pythonbrad pythonbrad marked this pull request as draft October 18, 2023 03:14
@pythonbrad pythonbrad marked this pull request as ready for review October 18, 2023 17:27
@pythonbrad
Copy link
Collaborator Author

The PR is enough like that. More change will be done in another PR.

@pythonbrad pythonbrad merged commit bcd189e into main Oct 18, 2023
5 checks passed
@pythonbrad pythonbrad deleted the rebase branch October 18, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pythonbrad pythonbrad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pythonbrad @coveralls