Use GSS.framework on Mac OS X #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In general, this looks good. Just a couple of small inline comments. |
|
I concur, this looks good to me as well. I think that creating header files to do this indirection is absolutely the right way to go. That said, this version does not work. In file "ext_cred_imp_exp.pyx", you need to change over to "python_gssapi_ext.h" from "gssapi/gssapi_ext.h", I think. Barring that @DirectXMan12's changes, this looks good to me. |
|
With new changes this is working, and looks good to me, though it needs to be squashed before ending up in master. |
On Mac OS X, Apple wants us to use the GSS.framework to compile against GSSAPI, instead of <gssapi/gssapi.h>. With this change we can choose headers to link against at compile time, without changing our source and header files.
DirectXMan12
force-pushed
the
mac_os_x_build
branch
from
0708492
to
d3b83e8
Compare
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Mac OS X, Apple wants us to use the GSS.framework to compile against GSSAPI, and
#include <GSS/...>instead of<gssapi/gssapi.h>. With this change we can choose headers to link against at compile time, without changing our source and header files.