Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade to torch 2.3.1 #2862

Closed
wants to merge 18 commits into from
Closed

chore: upgrade to torch 2.3.1 #2862

wants to merge 18 commits into from

Conversation

peri044
Copy link
Collaborator

@peri044 peri044 commented May 24, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

narendasan and others added 3 commits May 23, 2024 22:10
@narendasan @peri044
chore: Make from and to methods use the same TRT API (#2858)
381f60c 
Signed-off-by: Naren Dasan <naren@narendasan.com>
Signed-off-by: Naren Dasan <narens@nvidia.com>
@peri044
chore: updates
e191565
@peri044
chore: update torch version
8dab3e9
@github-actions github-actions bot added component: tests Issues re: Tests component: build system Issues re: Build system component: api [Python] Issues re: Python API labels May 24, 2024
@github-actions github-actions bot requested a review from narendasan May 24, 2024 17:09
@github-actions github-actions bot removed component: tests Issues re: Tests component: api [Python] Issues re: Python API labels May 24, 2024
@github-actions github-actions bot added the component: tests Issues re: Tests label May 24, 2024
@github-actions github-actions bot added the component: api [Python] Issues re: Python API label May 31, 2024
peri044
peri044 commented May 31, 2024
View reviewed changes
README.md
@@ -282,7 +282,7 @@ nox --session l0_api_tests

Supported Python versions:
```
["3.7", "3.8", "3.9", "3.10"]
["3.8", "3.9", "3.10", "3.11"]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need confirmation

@peri044
Copy link
Collaborator Author

peri044 commented May 31, 2024

Closing this in favor of #2875

@peri044 peri044 closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan Awaiting requested review from narendasan

Assignees
No one assigned
Labels
cla signed component: api [Python] Issues re: Python API component: build system Issues re: Build system component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peri044 @facebook-github-bot @narendasan