Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Make from and to methods use the same TRT API #2858

Merged
merged 2 commits into from
May 24, 2024
Merged

chore: Make from and to methods use the same TRT API #2858

merged 2 commits into from
May 24, 2024

Conversation

narendasan
Copy link
Collaborator

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@narendasan
chore: Make from and to methods use the same TRT API
aa4fe4e 
Signed-off-by: Naren Dasan <naren@narendasan.com>
Signed-off-by: Naren Dasan <narens@nvidia.com>
@github-actions github-actions bot added the component: api [Python] Issues re: Python API label May 23, 2024
@github-actions github-actions bot requested a review from peri044 May 23, 2024 20:38
@narendasan
refactor: Fix test dependencies
d84de7c 
Signed-off-by: Naren Dasan <naren@narendasan.com>
Signed-off-by: Naren Dasan <narens@nvidia.com>
@github-actions github-actions bot added the component: tests Issues re: Tests label May 23, 2024
peri044
peri044 approved these changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peri044 peri044 merged commit 543f436 into main May 24, 2024
58 checks passed
peri044 pushed a commit that referenced this pull request May 24, 2024
@narendasan @peri044
chore: Make from and to methods use the same TRT API (#2858)
381f60c 
Signed-off-by: Naren Dasan <naren@narendasan.com>
Signed-off-by: Naren Dasan <narens@nvidia.com>
peri044 added a commit that referenced this pull request May 24, 2024
@peri044 @narendasan
chore: cherry-pick of #2858 (#2861)
25a04ae 
Signed-off-by: Naren Dasan <naren@narendasan.com>
Signed-off-by: Naren Dasan <narens@nvidia.com>
Co-authored-by: Naren Dasan <1790613+narendasan@users.noreply.github.com>
laikhtewari pushed a commit that referenced this pull request May 24, 2024
@narendasan @laikhtewari
chore: Make from and to methods use the same TRT API (#2858)
55f1149 
Signed-off-by: Naren Dasan <naren@narendasan.com>
Signed-off-by: Naren Dasan <narens@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peri044 peri044 peri044 approved these changes

Assignees
No one assigned
Labels
cla signed component: api [Python] Issues re: Python API component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@narendasan @peri044 @facebook-github-bot