Migrating kaldi tests

[bhargavkathivarapu]

Hi ,
Regarding #597 , This PR moves tests from test/test_compliance_kaldi.py to test/kaldi_compatibility_impl.py

[bhargavkathivarapu]

@vincentqb ,

fbank, mfcc , spectrogram outputs between kaldi and torchaudio kaldi are not matching in a few cases as per the threshold defined . In other cases they are matching as per threshold .

For resample what is the kaldi command to get resampled waveform ? , for now I kept the kaldi result of resample to None

[mthrok]

Hi @bhargavkathivarapu

Thanks for working on this.

First, let's put migration of different types of tests into separate PRs and start from existing one. bank or mfcc.

Second, instead of simple text file, can you use JSON Lines format? (with .json extension) so that no string parsing is required in test code. then we do not have to add _get_func_args, _parse, and TEST_PREFIX.
JSON Lines format is one JSON object (dict with proper arg name and values) per line, which can be read like

def _load_jsonl(path):
    with open('file.json', 'r') as file:
        return [json.loads(line) for line in file]

Third, when working on different types of test, can you use different parameter files? One JSON Line file for fbank, one for mfcc etc...

Forth, the current implementation stops when there is one test error. Let's try using parameterized.expand to list all such failures.
@vincentqb This is my temporary suggestion for parameterization. PyTorch has some discussion going on pytorch/pytorch#11578 but this is stall. Once they implement their own parameterization, we can migrate it.

Combining the second and forth suggestions, the required change should be fairly simple.

From

def test_fbank(self):

to

@parameterized.expand(_load_jsonl(path_to_parameter_jsonl_file))
def test_fbank(self, kwargs):

And you will need to add dependencies to CI config here and here

[mthrok]

Please keep this inside of test each test. The intended usage of asset file is not immediately clear when someone else work on adding a new test, so it is not very suited to be common property.

[bhargavkathivarapu]

@mthrok ,Submitted another PR ( #672 ) just for fbank , includes below

1. Separate JSON file for each fbank args
2. Adding parameterized dependency to linux and windows yml files
3. Using the load json and parameterized.expand in tests

But the CI tests are not getting trigged for that pull request
I tried reverting the yaml to previous configuration without parametezied , but the commit is not triggering CI