Remove lazy behavior from MelScale #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthrok
approved these changes
Jul 21, 2021
| @@ -33,13 +33,14 @@ def test_batch_Resample(self): | |||
| self.assertEqual(computed, expected) | |||
|
|
|||
| def test_batch_MelScale(self): | |||
| specgram = torch.randn(2, 31, 2786) | |||
| n_stft = 31 | |||
| specgram = torch.randn(2, n_stft, 2786) | |||
There was a problem hiding this comment.
Can you use the default value of n_stft=201, so that we can catch an error for default value first if that happens in the future?
Also not sure where the 2786 is coming from, but I think we can use something shorter, like 256.
|
|
||
| # Single then transform then batch | ||
| expected = torchaudio.transforms.MelScale()(specgram).repeat(3, 1, 1, 1) | ||
| expected = torchaudio.transforms.MelScale(n_stft=n_stft)(specgram).repeat(3, 1, 1, 1) |
There was a problem hiding this comment.
Note: (follow-up, not the scope of this PR) For batch consistency test, use of repeated does not catch some edge case. #1315
We should update the logic at some point.
| @@ -56,7 +56,7 @@ def test_AmplitudeToDB(self): | |||
|
|
|||
| def test_melscale_load_save(self): | |||
| specgram = torch.ones(1, 1000, 100) | |||
| melscale_transform = transforms.MelScale() | |||
| melscale_transform = transforms.MelScale(n_stft=1000) | |||
There was a problem hiding this comment.
Instead of setting n_stft, can we change the shape of specgram to 1, 201, 100?
This is more of a personal preference but 1000 is somehow conspicuous.
nateanl
pushed a commit
to nateanl/audio
that referenced
this pull request
Jul 28, 2021
Rebases pytorch#1571; addresses pytorch#1569: "In 0.9.0 we are deprecating the lazy behavior of MelScale because it can make an invalid TorchScript object and it does not align with the design of torchaudio. Now in master branch, we can remove the implementation." Co-authored-by: Pankaj Patil <pankaj.patil2099@hotmail.com> Co-authored-by: moto <855818+mthrok@users.noreply.github.com> Co-authored-by: hwangjeff <jeffhwang@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebases #1571; addresses #1569:
"In 0.9.0 we are deprecating the lazy behavior of MelScale because it can make an invalid TorchScript object and it does not align with the design of torchaudio. Now in master branch, we can remove the implementation."