Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider isort as linter #5

Closed
VitalyFedyunin opened this issue Sep 20, 2021 · 3 comments
Closed

Consider isort as linter #5

VitalyFedyunin opened this issue Sep 20, 2021 · 3 comments

Comments

@VitalyFedyunin
Copy link
Contributor

Some of __init__.py imports are getting out of control, we should consider using https://pycqa.github.io/isort/ as hard linter and/or suggestion.

@pmeier
Copy link
Contributor

pmeier commented Sep 29, 2021

We recently opted to use ufmt as code formatter. It combines black and usort. AFAIK, isort had some issues on FB architecture. cc @NicolasHug

The final vote is still out, but if we go for it, I can send a PR adopting it here too.

@NicolasHug
Copy link
Member

Yes, ufmt was specifically made to match fb's internal arc lint.
If we expect pytorch/data to be modified from withing fbcode from time to time, I think it's much safe to keep fbcode linting and github linting in sync

@ejguan
Copy link
Contributor

ejguan commented Jan 11, 2022

Thanks to @pmeier , we have added pre-commit hook to run auto formatter. ufmt is also included to make everything sorted.
Closing this Issue.

@ejguan ejguan closed this as completed Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants