[#1782] Add max position params to speech recognition #1783
Conversation
|
Hi @mgaido91! Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
the failure seems unrelated to this PR, but I don't know how to retrigger the tests, can anyone help me? Thanks. |
|
@mgaido91 Windows never passes. |
| @@ -77,6 +77,10 @@ def add_args(parser): | |||
| parser.add_argument( | |||
| "--silence-token", default="\u2581", help="token for silence (used by w2l)" | |||
| ) | |||
| parser.add_argument('--max-source-positions', default=2048, type=int, metavar='N', | |||
There was a problem hiding this comment.
The default value of 2048 may be too small since in speech recognition the source is sequence of frames, not tokens.
With this change we may start filtering out large portion of librispeech data by default for example.
Maybe we can set default as sys.maxsize for both of the source and target sequence to keep existing behavior (no data filtering by max size).
| @@ -77,6 +77,10 @@ def add_args(parser): | |||
| parser.add_argument( | |||
| "--silence-token", default="\u2581", help="token for silence (used by w2l)" | |||
| ) | |||
| parser.add_argument('--max-source-positions', default=2048, type=int, metavar='N', | |||
| help='max number of tokens in the source sequence') | |||
|
Thanks for the review @okhonko . Is there anything else I can do to push this PR forward? Thanks in advance for the guidance. |
There was a problem hiding this comment.
@myleott has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Before submitting
What does this PR do?
Fixes #1782.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃