Skip to content

Commit

Permalink
Fix obviously-broken .clang-tidy files (#28547)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: pytorch/pytorch#28547

Pull Request resolved: #3672

See D18090864 for more background.  The issue i addressed there is more widespread, so i'm fixing all the other `.clang-tidy` files clearly not working as intended.

Perhaps this means it's time to lint the linter config :-)

Reviewed By: soumith

Differential Revision: D18092684

fbshipit-source-id: 951307d125c0346322cb2c636c0300004a48d7a9
  • Loading branch information
wfarner authored and facebook-github-bot committed Oct 28, 2019
1 parent a13d88d commit b1d464b
Showing 1 changed file with 25 additions and 26 deletions.
51 changes: 25 additions & 26 deletions .clang-tidy
Original file line number Diff line number Diff line change
@@ -1,30 +1,29 @@
---
# NOTE: there must be no spaces before the '-', so put the comma first.
Checks: '
*
,clang-diagnostic-*
,modernize-*
,clang-analyzer-*
,-clang-analyzer-alpha*
,-readability-named-parameter
,-misc-unused-parameters
,-google-runtime-references
,-google-build-using-namespace
,-cppcoreguidelines-pro-type-union-access
,-google-readability-casting
,-readability-implicit-bool-cast
,-google-readability-todo
,-readability-braces-around-statements
,-google-readability-braces-around-statements
,-performance-unnecessary-value-param
,-misc-unused-using-decls
,-modernize-pass-by-value
,-modernize-raw-string-literal
,-readability-else-after-return
,-readability-implicit-bool-conversion
,-cppcoreguidelines-pro-type-member-init
,-hicpp-member-init
,-cppcoreguidelines-pro-bounds-array-to-pointer-decay
# NOTE: there must be no spaces before the '-', so put the comma last.
Checks: '*,
clang-diagnostic-*,
modernize-*,
clang-analyzer-*,
-clang-analyzer-alpha*,
-readability-named-parameter,
-misc-unused-parameters,
-google-runtime-references,
-google-build-using-namespace,
-cppcoreguidelines-pro-type-union-access,
-google-readability-casting,
-readability-implicit-bool-cast,
-google-readability-todo,
-readability-braces-around-statements,
-google-readability-braces-around-statements,
-performance-unnecessary-value-param,
-misc-unused-using-decls,
-modernize-pass-by-value,
-modernize-raw-string-literal,
-readability-else-after-return,
-readability-implicit-bool-conversion,
-cppcoreguidelines-pro-type-member-init,
-hicpp-member-init,
-cppcoreguidelines-pro-bounds-array-to-pointer-decay
'
WarningsAsErrors: ''
HeaderFilterRegex: 'include/glow'
Expand Down

0 comments on commit b1d464b

Please sign in to comment.