Fix broken .clang-tidy file #3672
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D18092684 |
wfarner
changed the title
wfarner
changed the title
Summary: Pull Request resolved: pytorch/pytorch#28547 Pull Request resolved: pytorch#3672 See D18090864 for more background. The issue i addressed there is more widespread, so i'm fixing all the other `.clang-tidy` files clearly not working as intended. Perhaps this means it's time to lint the linter config :-) Reviewed By: soumith Differential Revision: D18092684 fbshipit-source-id: 46a1239a95be950e0b5d698c7a089c1070d65cc6
wfarner
force-pushed
the
export-D18092684
branch
from
7de98e4
to
d080d72
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18092684 |
wfarner
added a commit
to wfarner/pytorch
that referenced
this pull request
Oct 24, 2019
Summary: Pull Request resolved: pytorch#28547 Pull Request resolved: pytorch/glow#3672 See D18090864 for more background. The issue i addressed there is more widespread, so i'm fixing all the other `.clang-tidy` files clearly not working as intended. Perhaps this means it's time to lint the linter config :-) Test Plan: Here's the resulting output for `~/fbsource/fbcode/third-party-buck/platform007/build/llvm-fb/bin/clang-tidy` related to each file touched: `fbcode/admarket/intent/.clang-tidy`: P119723794 `fbcode/caffe2/.clang-tidy`: P119723978 `fbcode/glow/glow/.clang-tidy`: P119724081 `fbcode/ice_palace/.clang-tidy`: P119724774 `fbcode/unified_graph/aggregator/.clang-tidy`: P119724375 `xplat/caffe2/.clang-tidy`: P119724464 `xplat/mcfcpp/.clang-tidy`: ``` [billfarner@devvm2187.ftw3 ~/fbsource/xplat/mcfcpp] ~/fbsource/fbcode/third-party-buck/platform007/build/llvm-fb/bin/clang-tidy -explain-config 'readability-identifier-naming' is enabled in the /home/billfarner/fbsource/xplat/mcfcpp/.clang-tidy. ``` `xplat/wa-msys/mcfcpp/.clang-tidy`: ``` [billfarner@devvm2187.ftw3 ~/fbsource/xplat/wa-msys/mcfcpp] ~/fbsource/fbcode/third-party-buck/platform007/build/llvm-fb/bin/clang-tidy -explain-config 'readability-identifier-naming' is enabled in the /home/billfarner/fbsource/xplat/wa-msys/mcfcpp/.clang-tidy. ``` Reviewed By: soumith Differential Revision: D18092684 fbshipit-source-id: 8b26b1a74aacff85257e2309516c2741b1237670
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Oct 28, 2019
Summary: Pull Request resolved: #28547 Pull Request resolved: pytorch/glow#3672 See D18090864 for more background. The issue i addressed there is more widespread, so i'm fixing all the other `.clang-tidy` files clearly not working as intended. Perhaps this means it's time to lint the linter config :-) Test Plan: Here's the resulting output for `~/fbsource/fbcode/third-party-buck/platform007/build/llvm-fb/bin/clang-tidy` related to each file touched: `fbcode/admarket/intent/.clang-tidy`: P119723794 `fbcode/caffe2/.clang-tidy`: P119723978 `fbcode/glow/glow/.clang-tidy`: P119724081 `fbcode/ice_palace/.clang-tidy`: P119724774 `fbcode/unified_graph/aggregator/.clang-tidy`: P119724375 `xplat/caffe2/.clang-tidy`: P119724464 `xplat/mcfcpp/.clang-tidy`: ``` [billfarner@devvm2187.ftw3 ~/fbsource/xplat/mcfcpp] ~/fbsource/fbcode/third-party-buck/platform007/build/llvm-fb/bin/clang-tidy -explain-config 'readability-identifier-naming' is enabled in the /home/billfarner/fbsource/xplat/mcfcpp/.clang-tidy. ``` `xplat/wa-msys/mcfcpp/.clang-tidy`: ``` [billfarner@devvm2187.ftw3 ~/fbsource/xplat/wa-msys/mcfcpp] ~/fbsource/fbcode/third-party-buck/platform007/build/llvm-fb/bin/clang-tidy -explain-config 'readability-identifier-naming' is enabled in the /home/billfarner/fbsource/xplat/wa-msys/mcfcpp/.clang-tidy. ``` Reviewed By: soumith Differential Revision: D18092684 fbshipit-source-id: 951307d125c0346322cb2c636c0300004a48d7a9
|
This pull request has been merged in b1d464b. |
vdantu
pushed a commit
to vdantu/glow
that referenced
this pull request
Jul 12, 2020
Summary: Pull Request resolved: pytorch/pytorch#28547 Pull Request resolved: pytorch#3672 See D18090864 for more background. The issue i addressed there is more widespread, so i'm fixing all the other `.clang-tidy` files clearly not working as intended. Perhaps this means it's time to lint the linter config :-) Reviewed By: soumith Differential Revision: D18092684 fbshipit-source-id: 951307d125c0346322cb2c636c0300004a48d7a9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The syntax in
.clang-tidydoes not have the desired effect. Fixed formatting so that rules in the config are observed.Differential Revision: D18092684