Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile error when building glow #6054

Open
nikola-suljagic opened this issue Feb 12, 2023 · 6 comments
Open

Compile error when building glow #6054

nikola-suljagic opened this issue Feb 12, 2023 · 6 comments

Comments

@nikola-suljagic
Copy link

nikola-suljagic commented Feb 12, 2023

Hi to all,
Can someone help me why I encountered error when building Glow:

image

It looks like that in thirdparty/folly/folly/TimeoutQueue.cpp is missed to include header file as you can see from above image. But it's weird to me, it looks that some part of my system isn't compatible.
I'm using llvm-15 and Ubuntu 22.04 linux distribution.

Did I miss something?

Thanks in advance!!!

@HamzaBenHaj
Copy link

same issue here

@harishch4
Copy link

I was able to solve it by adding #include to TimeoutQueue.cpp, but there seems to be other build issues on master branch. Does any able to build successfully?

@jankraing
Copy link

This does not directly solve the issue but I only managed to successfully build glow in a docker container using ubuntu/bionic as base image.

@fvalasiad
Copy link

Kinda late but.

#include <limits>

@m-peko
Copy link

m-peko commented Aug 22, 2023

Checking out to one of earlier versions of Folly (v2022.12.19.00) and GoogleBenchmark (v1.3.0) worked for me.
It may work with a bit newer versions of these dependencies but I haven't put an additional effort into trying that.

In addition to above changes, I also needed to add #include <cstddef> to test_libjit.cpp file.

@coolshark777
Copy link

Hi @m-peko,
I tried Folly (v2022.12.19.00) using LLVM-15, still got many compilation errors, did I miss something?

/usr/local/include/fmt/base.h:1597:3: error: static assertion failed due to requirement 'formattable_char': Mixing character types is disallowed.
static_assert(formattable_char, "Mixing character types is disallowed.");
^ ~~~~~~~~~~~~~~~~
/usr/local/include/fmt/base.h:2005:20: note: in instantiation of function template specialization 'fmt::detail::make_arg<true, fmt::context, folly::Range<const char *>, 0>' requested here
return {{detail::make_arg<NUM_ARGS <= detail::max_packed_args, Context>(
^
/usr/local/include/fmt/format.h:4366:28: note: in instantiation of function template specialization 'fmt::make_format_args<fmt::context, folly::Range<const char *>, 1UL, 0UL, 15ULL, 0>' requested here
return vformat(fmt, fmt::make_format_args(args...));
^
/home/leon/dlrm/glow/thirdparty/folly/folly/IPAddressV4.cpp:73:14: note: in instantiation of function template specialization 'fmt::format<folly::Range<const char *> &>' requested here
fmt::format("Can't convert invalid IP '{}' to long", ip));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants