Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install with Poetry Fails #47

Closed
Queuecumber opened this issue Dec 24, 2020 · 3 comments
Closed

Install with Poetry Fails #47

Queuecumber opened this issue Dec 24, 2020 · 3 comments

Comments

@Queuecumber
Copy link

Currently

poetry add git+https://github.com/pytorch/hydra-torch

fails with

  RuntimeError

  The dependency name for hydra-configs-torch does not match the actual package's name: hydra-torch

  at ~/.local/lib/python3.6/site-packages/poetry/puzzle/provider.py:293 in get_package_from_directory
      289│         if name and name != package.name:
      290│             # For now, the dependency's name must match the actual package's name
      291│             raise RuntimeError(
      292│                 "The dependency name for {} does not match the actual package's name: {}".format(
    → 293│                     name, package.name
      294│                 )
      295│             )
      296│ 
      297│         return package

may be worth looking into if this is a poetry problem or a packaging problem

@romesco
Copy link
Contributor

romesco commented Dec 24, 2020

Hey Max!

For now, try this out:
poetry add git+https://github.com/pytorch/hydra-torch/#subdirectory=hydra-configs-torch

You'll notice that this is adding the single package, hydra-configs-torch, which is in it's respective project directory. This 'dependency name' has the same name as the package name.

We haven't finalized the metapackage yet, and right now that's the one you're trying to add. I think this bug is half on our end and half on poetry's end. Let's circle back on it once we have an initial metapackage release!

@romesco romesco closed this as completed Dec 24, 2020
@Queuecumber
Copy link
Author

poetry run pip install git+https://github.com/pytorch/hydra-torch works, but poetry itself doesn't support subfolders yet. The problem should resolve itself when there's a pypi release though so not a big deal.

@jzazo
Copy link

jzazo commented Feb 7, 2022

Hi. The above poetry add command fails. How should we install this package with poetry? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants