Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hydra-configs-torch] Configs for Linear / Conv Modules #9

Open
romesco opened this issue Oct 8, 2020 · 4 comments
Open

[hydra-configs-torch] Configs for Linear / Conv Modules #9

romesco opened this issue Oct 8, 2020 · 4 comments

Comments

@romesco
Copy link
Contributor

romesco commented Oct 8, 2020

Generate these module confs, brainstorm robust testing method.

@omry
Copy link
Contributor

omry commented Oct 9, 2020

I think this is probably too challenging for an initial example.
We can have the network defined in code (as it is now) and instantiate it with instantiate.

If you want to break new ground with allowing full control of the network initially, you can probably try it out first "on the side". We should probably not add config classes to things before we are actually sure these are useful (initially these can be a part of the test app, generated by configen or by hand).

@romesco
Copy link
Contributor Author

romesco commented Oct 9, 2020

Which config classes are you suggesting might not be useful? I'm thinking many of the nn/modules ones would be, right?

@romesco
Copy link
Contributor Author

romesco commented Oct 9, 2020

Or did you mean for that comment to be in the context of the MNIST example (which there is a separate issue for tracking =P).

@omry
Copy link
Contributor

omry commented Oct 9, 2020

optimizer, dataset, model (at a high level).
See the PL Hydra PR.

@romesco romesco changed the title torch/nn/modules - Linear / Conv modules [hydra-torch-configs] Configs for Linear / Conv Modules Dec 19, 2020
@romesco romesco changed the title [hydra-torch-configs] Configs for Linear / Conv Modules [hydra-configs-torch] Configs for Linear / Conv Modules Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants