-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opcheck has dependency on expecttest, which is not a pytorch runtime dependency, leading to "module not found" error message #126870
Labels
module: opcheck
Related to opcheck testing for custom operators
module: pt2-dispatcher
PT2 dispatcher-related issues (e.g., aotdispatch, functionalization, faketensor, custom-op,
oncall: pt2
triaged
This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Milestone
Comments
zou3519
added a commit
that referenced
this issue
May 28, 2024
This PR excises opcheck's dependency on torch.testing._internal.common_utils, (which comes with dependencies on expecttest and hypothesis). We do this by moving what we need to torch.testing._utils and adding a test for it. Fixes #126870, #126871 Test Plan: - new tests ghstack-source-id: 02fe50fceb83ea3d29b6595b4ceda187b78892ac Pull Request resolved: #127292
zou3519
added a commit
that referenced
this issue
May 28, 2024
This PR excises opcheck's dependency on torch.testing._internal.common_utils, (which comes with dependencies on expecttest and hypothesis). We do this by moving what we need to torch.testing._utils and adding a test for it. Fixes #126870, #126871 Test Plan: - new tests ghstack-source-id: 944831a31155ae4f6c0b0c666914a75c17de42af Pull Request resolved: #127292
zou3519
added a commit
that referenced
this issue
May 28, 2024
…dependencies" This PR excises opcheck's dependency on torch.testing._internal.common_utils, (which comes with dependencies on expecttest and hypothesis). We do this by moving what we need to torch.testing._utils and adding a test for it. Fixes #126870, #126871 Test Plan: - new tests [ghstack-poisoned]
There isn't really any reason for opcheck to hard depend on expecttest imo |
zou3519
added a commit
that referenced
this issue
May 29, 2024
…dependencies" This PR excises opcheck's dependency on torch.testing._internal.common_utils, (which comes with dependencies on expecttest and hypothesis). We do this by moving what we need to torch.testing._utils and adding a test for it. Fixes #126870, #126871 Test Plan: - new tests [ghstack-poisoned]
zou3519
added a commit
that referenced
this issue
May 29, 2024
…dependencies" This PR excises opcheck's dependency on torch.testing._internal.common_utils, (which comes with dependencies on expecttest and hypothesis). We do this by moving what we need to torch.testing._utils and adding a test for it. Fixes #126870, #126871 Test Plan: - new tests [ghstack-poisoned]
zou3519
added a commit
that referenced
this issue
May 29, 2024
…dependencies" This PR excises opcheck's dependency on torch.testing._internal.common_utils, (which comes with dependencies on expecttest and hypothesis). We do this by moving what we need to torch.testing._utils and adding a test for it. Fixes #126870, #126871 Test Plan: - new tests [ghstack-poisoned]
zou3519
added a commit
that referenced
this issue
May 29, 2024
…dependencies" This PR excises opcheck's dependency on torch.testing._internal.common_utils, (which comes with dependencies on expecttest and hypothesis). We do this by moving what we need to torch.testing._utils and adding a test for it. Fixes #126870, #126871 Test Plan: - new tests [ghstack-poisoned]
Aidyn-A
pushed a commit
to tinglvv/pytorch
that referenced
this issue
May 30, 2024
This PR excises opcheck's dependency on torch.testing._internal.common_utils, (which comes with dependencies on expecttest and hypothesis). We do this by moving what we need to torch.testing._utils and adding a test for it. Fixes pytorch#126870, pytorch#126871 Test Plan: - new tests Pull Request resolved: pytorch#127292 Approved by: https://github.com/williamwen42 ghstack dependencies: pytorch#127291
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
module: opcheck
Related to opcheck testing for custom operators
module: pt2-dispatcher
PT2 dispatcher-related issues (e.g., aotdispatch, functionalization, faketensor, custom-op,
oncall: pt2
triaged
This issue has been looked at a team member, and triaged and prioritized into an appropriate module
easiest way to repro is to grab a colab (colab doesn't come with expecttest)
cc @ezyang @msaroufim @bdhirsh @anijain2305 @chauhang
The text was updated successfully, but these errors were encountered: