-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
running opcheck leads to Fail to import hypothesis in common_utils, tests are not derandomized
print
#126871
Closed
Tracked by
#130151
Labels
module: opcheck
Related to opcheck testing for custom operators
module: pt2-dispatcher
PT2 dispatcher-related issues (e.g., aotdispatch, functionalization, faketensor, custom-op,
oncall: pt2
triaged
This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Milestone
Comments
zou3519
added a commit
that referenced
this issue
May 28, 2024
…dependencies" This PR excises opcheck's dependency on torch.testing._internal.common_utils, (which comes with dependencies on expecttest and hypothesis). We do this by moving what we need to torch.testing._utils and adding a test for it. Fixes #126870, #126871 Test Plan: - new tests [ghstack-poisoned]
zou3519
added a commit
that referenced
this issue
May 29, 2024
…dependencies" This PR excises opcheck's dependency on torch.testing._internal.common_utils, (which comes with dependencies on expecttest and hypothesis). We do this by moving what we need to torch.testing._utils and adding a test for it. Fixes #126870, #126871 Test Plan: - new tests [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this issue
May 29, 2024
This PR excises opcheck's dependency on torch.testing._internal.common_utils, (which comes with dependencies on expecttest and hypothesis). We do this by moving what we need to torch.testing._utils and adding a test for it. Fixes #126870, #126871 Test Plan: - new tests Pull Request resolved: #127292 Approved by: https://github.com/williamwen42 ghstack dependencies: #127291
Fixed by #127292 |
zou3519
added a commit
that referenced
this issue
May 29, 2024
…dependencies" This PR excises opcheck's dependency on torch.testing._internal.common_utils, (which comes with dependencies on expecttest and hypothesis). We do this by moving what we need to torch.testing._utils and adding a test for it. Fixes #126870, #126871 Test Plan: - new tests [ghstack-poisoned]
zou3519
added a commit
that referenced
this issue
May 29, 2024
…dependencies" This PR excises opcheck's dependency on torch.testing._internal.common_utils, (which comes with dependencies on expecttest and hypothesis). We do this by moving what we need to torch.testing._utils and adding a test for it. Fixes #126870, #126871 Test Plan: - new tests [ghstack-poisoned]
zou3519
added a commit
that referenced
this issue
May 29, 2024
…dependencies" This PR excises opcheck's dependency on torch.testing._internal.common_utils, (which comes with dependencies on expecttest and hypothesis). We do this by moving what we need to torch.testing._utils and adding a test for it. Fixes #126870, #126871 Test Plan: - new tests [ghstack-poisoned]
pytorch-bot bot
pushed a commit
that referenced
this issue
May 30, 2024
This PR excises opcheck's dependency on torch.testing._internal.common_utils, (which comes with dependencies on expecttest and hypothesis). We do this by moving what we need to torch.testing._utils and adding a test for it. Fixes #126870, #126871 Test Plan: - new tests Pull Request resolved: #127292 Approved by: https://github.com/williamwen42 ghstack dependencies: #127291
29 tasks
@zou3519 I still see this warning on 2.4.0 rc:
|
@atalman the way to verify this is:
and see if that raises an error |
Validated I can run tutorial successfully : https://pytorch.org/tutorials/advanced/python_custom_ops.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
module: opcheck
Related to opcheck testing for custom operators
module: pt2-dispatcher
PT2 dispatcher-related issues (e.g., aotdispatch, functionalization, faketensor, custom-op,
oncall: pt2
triaged
This issue has been looked at a team member, and triaged and prioritized into an appropriate module
likely shouldn't happen
cc @ezyang @msaroufim @bdhirsh @anijain2305 @chauhang
The text was updated successfully, but these errors were encountered: