Skip to content

[reland][complex32] conv1d, conv2d : enable test #77999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

[reland][complex32] conv1d, conv2d : enable test #77999

wants to merge 9 commits into from

Conversation

@kshitij12345
Copy link
Collaborator

Reland: #77239
Ref: #74537

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 20, 2022 •
edited
Loading

🔗 Helpful links

❌ 1 New Failures

As of commit 4c55b70 (more details on the Dr. CI page):

Expand to see more
  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build trunk / win-vs2019-cuda11.3-py3 / test (force_on_cpu, 1, 1, windows.4xlarge) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-05-21T13:24:43.0365702Z ls: cannot access ...d/win_tmp/ci_scripts/*': No such file or directory 
2022-05-21T13:24:42.9427222Z + export TEST_DIR_WIN
2022-05-21T13:24:42.9427487Z + export PYTORCH_FINAL_PACKAGE_DIR=/c/2362358115/build-results/
2022-05-21T13:24:42.9427786Z + PYTORCH_FINAL_PACKAGE_DIR=/c/2362358115/build-results/
2022-05-21T13:24:42.9492297Z ++ cygpath -w /c/2362358115/build-results/
2022-05-21T13:24:42.9599090Z + PYTORCH_FINAL_PACKAGE_DIR_WIN='C:\2362358115\build-results\'
2022-05-21T13:24:42.9599405Z + export PYTORCH_FINAL_PACKAGE_DIR_WIN
2022-05-21T13:24:42.9599705Z + mkdir -p /c/actions-runner/_work/pytorch/pytorch/build/win_tmp/build/torch
2022-05-21T13:24:42.9864473Z + CI_SCRIPTS_DIR=/c/actions-runner/_work/pytorch/pytorch/build/win_tmp/ci_scripts
2022-05-21T13:24:42.9864865Z + mkdir -p /c/actions-runner/_work/pytorch/pytorch/build/win_tmp/ci_scripts
2022-05-21T13:24:43.0062520Z ++ ls '/c/actions-runner/_work/pytorch/pytorch/build/win_tmp/ci_scripts/*'
2022-05-21T13:24:43.0365702Z ls: cannot access '/c/actions-runner/_work/pytorch/pytorch/build/win_tmp/ci_scripts/*': No such file or directory
2022-05-21T13:24:43.0368793Z + '[' -n '' ']'
2022-05-21T13:24:43.0369570Z + export SCRIPT_HELPERS_DIR=/c/actions-runner/_work/pytorch/pytorch/.jenkins/pytorch/win-test-helpers
2022-05-21T13:24:43.0370022Z + SCRIPT_HELPERS_DIR=/c/actions-runner/_work/pytorch/pytorch/.jenkins/pytorch/win-test-helpers
2022-05-21T13:24:43.0370349Z + [[ win-vs2019-cuda11.3-py3 == *cuda11* ]]
2022-05-21T13:24:43.0370583Z + export BUILD_SPLIT_CUDA=ON
2022-05-21T13:24:43.0370789Z + BUILD_SPLIT_CUDA=ON
2022-05-21T13:24:43.0371001Z + [[ force_on_cpu = \f\o\r\c\e\_\o\n\_\c\p\u ]]
2022-05-21T13:24:43.0371218Z + export USE_CUDA=0
2022-05-21T13:24:43.0371875Z + USE_CUDA=0
2022-05-21T13:24:43.0372091Z + [[ win-vs2019-cuda11.3-py3 == *cuda* ]]
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

kshitij12345
kshitij12345 commented May 20, 2022
View reviewed changes
torch/testing/_internal/common_methods_invocations.py
DecorateInfo(
toleranceOverride({torch.chalf: tol(atol=1e-2, rtol=1e-2)}),
'TestCudaFuserOpInfo', 'test_nvfuser_correctness',
),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relaxed tolerance for nvFuser test.

@kshitij12345 kshitij12345 marked this pull request as ready for review May 20, 2022 19:53
@kshitij12345 kshitij12345 requested a review from anjali411 May 20, 2022 19:53
@mrshenli mrshenli added triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module module: complex Related to complex number support in PyTorch labels May 22, 2022
@kshitij12345 kshitij12345 added the module: half Related to float16 half-precision floats label May 23, 2022
@kshitij12345
Copy link
Collaborator Author

kshitij12345 commented May 23, 2022 •
edited
Loading

@pytorchbot merge

@kshitij12345
Copy link
Collaborator Author

@pytorchbot merge

@github-actions
Copy link
Contributor

Hey @kshitij12345.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request May 24, 2022
@kshitij12345 @facebook-github-bot
[reland][complex32] conv1d, conv2d enable test (#77999) (#77999)
e14e55a 
Summary:
Reland: #77239
Ref: #74537

Pull Request resolved: #77999
Approved by: https://github.com/anjali411

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/88fca3be5924dd089235c72e651f3709e18f76b8

Reviewed By: seemethere

Differential Revision: D36610481

Pulled By: seemethere

fbshipit-source-id: bc57137c63e61f131409c0c38ac79af352353d0b
swang392 pushed a commit that referenced this pull request May 25, 2022
@kshitij12345 @swang392
[reland][complex32] conv1d, conv2d : enable test (#77999)
53d6f32 
Reland: #77239
Ref: #74537
Pull Request resolved: #77999
Approved by: https://github.com/anjali411
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anjali411 anjali411 anjali411 approved these changes

@mruberry mruberry Awaiting requested review from mruberry

@ngimel ngimel Awaiting requested review from ngimel

Assignees

No one assigned

Labels

cla signed Merged module: complex Related to complex number support in PyTorch module: half Related to float16 half-precision floats open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kshitij12345 @facebook-github-bot @anjali411 @mrshenli @pytorchbot @pytorchmergebot