Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[export] Serialize symbolic values #103273

Closed
wants to merge 6 commits into from
Closed

[export] Serialize symbolic values #103273

wants to merge 6 commits into from

Commits on Jun 8, 2023

  1. [export] Serialize shape 

    [ghstack-poisoned]
    @angelayi
    angelayi committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    9822176 View commit details
    Browse the repository at this point in the history

  2. Update on "[export] Serialize shape" 

    [ghstack-poisoned]
    @angelayi
    angelayi committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    e329a38 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2023

  1. Update on "[export] Serialize symbolic values" 

    * Serialized range constraints and inline constraints into symbols represented as strings
* These symbols are then reconstructed in the deserialize_sym_int/bool functions by adding them to the shape env along with the ranges.
* Modified the SymInt schema to also store the hint of the SymInt if it is represented as a symbol so that when we reconstruct the SymInt, the hint will also exist on the node.
* GraphModuleDeserializer.deserialize now also optionally takes in a shape env and map of symbols to names.

ReplaceSymSizeOpPass should not be needed after #103107 lands




[ghstack-poisoned]
    @angelayi
    angelayi committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    f3b184b View commit details
    Browse the repository at this point in the history

  2. Update on "[export] Serialize symbolic values" 

    * Serialized range constraints and inline constraints into symbols represented as strings
* These symbols are then reconstructed in the deserialize_sym_int/bool functions by adding them to the shape env along with the ranges.
* Modified the SymInt schema to also store the hint of the SymInt if it is represented as a symbol so that when we reconstruct the SymInt, the hint will also exist on the node.
* GraphModuleDeserializer.deserialize now also optionally takes in a shape env and map of symbols to names.

ReplaceSymSizeOpPass should not be needed after #103107 lands




[ghstack-poisoned]
    @angelayi
    angelayi committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    c821dc1 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. Update on "[export] Serialize symbolic values" 

    * Modified the SymInt schema to also store the hint of the SymInt if it is represented as a symbol so that when we reconstruct the SymInt, the hint will also exist on the node.
* GraphModuleDeserializer.deserialize now also optionally map of symbol names to range.

ReplaceSymSizeOpPass should not be needed after #103107 lands




[ghstack-poisoned]
    @angelayi
    angelayi committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    cc73723 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. Update on "[export] Serialize symbolic values" 

    * Modified the SymInt schema to also store the hint of the SymInt if it is represented as a symbol so that when we reconstruct the SymInt, the hint will also exist on the node.
* GraphModuleDeserializer.deserialize now also optionally map of symbol names to range.

ReplaceSymSizeOpPass should not be needed after #103107 lands




[ghstack-poisoned]
    @angelayi
    angelayi committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    ed4ef55 View commit details
    Browse the repository at this point in the history