Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[caffe2] Clean up platform-specific fbobjc deps/flags #106193

Closed
wants to merge 1 commit into from
Closed

[caffe2] Clean up platform-specific fbobjc deps/flags #106193

wants to merge 1 commit into from

Conversation

andrewjcg
Copy link
Contributor

Summary:
Replace platform_deps with select()s and use to make sure the cpukernel_avx2
dep is x86-specific.

https://fb.prod.workplace.com/groups/buck2users/posts/3469961626593527/

Test Plan:

$ buck2 build //xplat/rtc/media/tools/newton:newton_pcAppleMac#macosx-arm64 --target-platforms //xplat/rtc/webrtc/platforms:bwe-dbg-arm64

Differential Revision: D47844555

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 28, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/106193

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4d44484 with merge base b3e24c5 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47844555

@andrewjcg @facebook-github-bot
[caffe2] Clean up platform-specific fbobjc deps/flags (pytorch#106193)
4d44484 
Summary:
Pull Request resolved: pytorch#106193

Replace `platform_deps` with `select()`s and use to make sure the `cpukernel_avx2`
dep is x86-specific.

https://fb.prod.workplace.com/groups/buck2users/posts/3469961626593527/

Test Plan:
```
$ buck2 build //xplat/rtc/media/tools/newton:newton_pcAppleMac#macosx-arm64 --target-platforms //xplat/rtc/webrtc/platforms:bwe-dbg-arm64
```

Differential Revision: D47844555

fbshipit-source-id: c300a37ce924f198b6c0ef7c20c1ea78d9458fe0
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47844555

@andrewjcg
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jul 28, 2023
@github-actions
Copy link

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Sep 26, 2023
@github-actions github-actions bot closed this Oct 26, 2023
@malfet malfet reopened this Oct 26, 2023
@malfet
Copy link
Contributor

malfet commented Oct 26, 2023

@pytorchbot merge -f "This has been landed a long time ago internally"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch merge --squash __pull-request-106193__init__ returned non-zero exit code 1

Auto-merging c2_defs.bzl
CONFLICT (content): Merge conflict in c2_defs.bzl
Squash commit -- not updating HEAD
Automatic merge failed; fix conflicts and then commit the result.
Details for Dev Infra team Raised by workflow job

@kit1980
Copy link
Member

kit1980 commented Oct 26, 2023

The changes already landed as #96966

@malfet malfet closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

Assignees
No one assigned
Labels
fb-exported Stale topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andrewjcg @facebook-github-bot @malfet @pytorchmergebot @kit1980